1784044 - [Colorway Closet] The Intensity radio buttons are not correctly aligned with the "Soft", "Balanced", "Bold" strings

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P2)

Description

[Alin Ilea, Desktop QA]

Attachment: radio buttons issue.png

Found in

Firefox 105.0a1

Affected versions

105.0a1

Affected platforms

macOS 11.6
macOS 12
Windows 10
Ubuntu 20

Preconditions

In about:config set:
"browser.theme.colorway-closet" to true
"browser.tabs.firefox-view" to true

Steps to reproduce

1. Open Colorways modal from Fxview or from about:addons

Expected result

The Intensity radio buttons should be aligned/centered accordingly with the "Soft", "Balanced", "Bold" strings.

Actual result

The Intensity radio buttons are not properly aligned/centered with the "Soft", "Balanced", "Bold" strings.

Regression range

Not a regression.

Comment 1

[Dão Gottwald [:dao]]

Are you sure all platforms are affected? Personally I'm not seeing this on Ubuntu 22.04.

Comment 2

[Alin Ilea, Desktop QA]

Attachment: macOS 12.png

Indeed using macOS and Ubuntu the issue is not so noticeable as it is on Windows, but I still see a small difference between the radio button and string. The string seems a little lower than the radio button.

Comment 3

[Alin Ilea, Desktop QA]

Attachment: Ubuntu 20.png

Ubuntu 20

Comment 4

[Dão Gottwald [:dao]]

Attachment: Bug 1784044 - Center-align intensity radio buttons with their label. r=amy

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fb8a9f191853
Center-align intensity radio buttons with their label. r=bigiri

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fb8a9f191853

Comment 7

[Alin Ilea, Desktop QA]

Verified - Fixed in latest Nightly 105.0a1 (build id: 20220816095503) using Windows 10, macOS 11.6 and Ubuntu 20.04. The intensity radio buttons are center-aligned accordingly.