1784327 - YouTube video color glitches with force-enabled HW WR on Raspberry Pi4: Fixed in Mesa 22.2.4

Status: VERIFIED MOVED

(Core :: Graphics: WebRender, defect, P3)

Description

[Darkspirit]

Attachment: Screenshot from 2022-08-11 19-15-54.png

Screenshot = https://youtu.be/1La4QzGeaaQ?t=20

Nightly build from bug 1738814 comment 21
on 64 bit Raspberry Pi OS (Debian bullseye) + apt install -t testing libegl-mesa0 --no-install-recommends (Mesa 22.2.0~rc1) from bookworm

No difference with gfx.webrender.pbo-uploads=true&false and media.ffmpeg.customized-buffer-allocation=true&false.

Comment 1

[Darkspirit]

Attachment: Screenshot from 2022-08-11 19-26-30.png

There should be no pink.
Screenshot = https://youtu.be/9wJDmknSX-o?t=25

Comment 2

[Darkspirit]

Attachment: 2022-08-11_aboutsupport-freshprofile-wr-force-enabled.json

Comment 3

[Darkspirit]

Attachment: eglinfo.txt

Also occurs with HW WR on Gnome Xwayland and Gnome Wayland (MOZ_ENABLE_WAYLAND=1 is required either because libgtk-3-common 3.24.24-4+rpt4+deb11u2 is lower than Nightly's min version limit of 3.24.30 or because EARLY_BETA_OR_EARLIER is not set although the try build is a Nightly).

Comment 4

[Robert Mader [:rmader]]

This looks like a shader issue to me (YUV -> RGB) - something that would have to be fixed in Mesa. I'm just a bit surprised, given that such shaders are relatively common and probably very similar in different projects.

either because libgtk-3-common 3.24.24-4+rpt4+deb11u2 is lower than Nightly's min version limit of 3.24.30 or because EARLY_BETA_OR_EARLIER is not set although the try build is a Nightly).

The former - the same build chooses the Wayland backend on my Pinebook Pro on Arch.

Comment 5

[Robert Mader [:rmader]]

Can you check if this issue persists with gfx.egl.prefer-gles.enabled:true?

Comment 6

[Darkspirit]

(In reply to Robert Mader [:rmader] from comment #5)

Can you check if this issue persists with gfx.egl.prefer-gles.enabled:true?

Still occurs with try build from bug 1784453 comment 8 (gfx.egl.prefer-gles.enabled=true) and gfx.webrender.all=true.

Comment 7

[Robert Mader [:rmader]]

I see, thanks :/ Time for a Mesa issue then - I don't think there's more we can do here. Mind opening one or should I do?

Comment 8

[Robert Mader [:rmader]]

Opened https://gitlab.freedesktop.org/mesa/mesa/-/issues/7062

Comment 9

[Darkspirit]

(In reply to Robert Mader [:rmader] from comment #5)

Can you check if this issue persists with gfx.egl.prefer-gles.enabled:true?

(GLES 3 is used in any case because OGL is 2.1 at maximum. Flipping the pref just prevents the fallback from OGL to GLES by directly using GLES.)

Comment 10

[Brad Werth [:bradwerth]]

Robert, are you willing to be this Bug's assignee while the Mesa issue is being worked?

Comment 11

[Robert Mader [:rmader]]

(In reply to Brad Werth [:bradwerth] from comment #10)

Robert, are you willing to be this Bug's assignee while the Mesa issue is being worked?

Err, sure, can take it.

FTR: I'm unsure if this bug is bad enough to disable HW-WR as long as it's not fixed in Mesa. The improved performance and increased pressure on Mesa devs may be worth to just sit it out.

Comment 12

[Darkspirit]

(In reply to Robert Mader [:rmader] from comment #11)

The improved performance and increased pressure on Mesa devs may be worth to just sit it out.

That seems best. Maybe this is even a bug caused by me having a FrankenDebian.

Debian Bookworm (currently Debian testing) with Mesa 22.2 (HW WR Raspi baseline: bug 1783924) will become stable in ~summer 2023.

Raspberry Pi OS is Debian Stable plus an additional package repository (https://archive.raspberrypi.org/debian/dists/) with some modified Debian Stable packages like the kernel.
https://archive.raspberrypi.org/debian/dists/ doesn't contain bookworm yet.

https://wiki.debian.org/RaspberryPi4

Current status (2021-06)
Debian bullseye (and buster-backports) kernel (Linux 5.10) supports most of what is required (except hardware-accelerated 3D graphics).

Because of this message I have never tried to run a pure Debian testing so far. I'll try to flash an SD card with it tomorrow.

Comment 13

[pbrobinson]

For reference we're seeing this on Fedora 37 too and all the RPi accelerated pieces are enabled there by default.

Comment 14

[Robert Mader [:rmader]]

There's a pending patch for Mesa, in case anyone can give it a try: https://gitlab.freedesktop.org/mesa/mesa/-/issues/7062#note_1630720

Comment 15

[Robert Mader [:rmader]]

https://gitlab.freedesktop.org/mesa/mesa/-/issues/7062 has landed in Mesa main and will also get backported to 22.2 IIUC.

Comment 16

[Darkspirit]

Verfied fixed with Mesa 22.2.4 and autoland Nightly build from https://hg.mozilla.org/integration/autoland/rev/a1dc4d4c47df2e5448c995a0ad18cc8b98d05182. Thanks!