1784408 - remove Thunderbird usage of XUL flex="N" where N is not 0 or 1

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, task)

Description

[Magnus Melin [:mkmelin] (away, back Aug 4)]

+++ This bug was initially created as a clone of Bug # 1784265 +++

grep --exclude-dir=suite --exclude-dir=.hg -r 'flex="' | grep -v 'flex="1"'

Seems mostly used for treecol.
Some of these are likely not needed. Others can be replaced with style=-moz-box-flex: <number>

Comment 1

[Richard Marti (:Paenglab)]

Attachment: Bug 1784408 - Port bug 1784265: Drop support for flex attribute values other than 0 and 1. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/40f49f187486
Port bug 1784265: Drop support for flex attribute values other than 0 and 1. r=mkmelin

Comment 3

[b1]

You missed:
https://searchfox.org/comm-central/search?q=searchTerm.*FlexValue&path=.dtd&case=false&regexp=true
and more importantly
https://searchfox.org/l10n/search?q=searchTerm.*FlexValue&path=&case=false&regexp=true

This https://searchfox.org/comm-central/rev/4e4fef324e845be075f07a795fade91aa10d6d9a/mailnews/search/content/searchTerm.inc.xhtml#19-24 is a horrible attempt to localise the flexing in the search term editor by transferring localisable flex values from a hidden tree onto list cells.
Careful when removing that hidden tree, it's used here:
https://searchfox.org/comm-central/rev/4e4fef324e845be075f07a795fade91aa10d6d9a/mailnews/search/content/searchTerm.js#452,458
Sadly not accessed via ID but rather position in the DOM.

Comment 4

[Richard Marti (:Paenglab)]

(In reply to b1 from comment #3)

You missed:
https://searchfox.org/comm-central/search?q=searchTerm.*FlexValue&path=.dtd&case=false&regexp=true

Did I? https://hg.mozilla.org/comm-central/rev/40f49f1874860670a07d94a6cfb468ac6ebef334#l53.12

Comment 5

[b1]

Oops, sorry, apologies, didn't read to the end :-( - The mechanism is still rather questionable.

Comment 6

[Magnus Melin [:mkmelin] (away, back Aug 4)]

A try run with the diagnostics patch found one case we missed.

Comment 7

[Magnus Melin [:mkmelin] (away, back Aug 4)]

Attachment: Bug 1784408 - Remove unsupported flex attribute in menulist-editable. r=Paenglab

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/dd19aae1bd0a
Remove unsupported flex attribute in menulist-editable. r=Paenglab