1784432 - The "List all tabs" menu cannot be opened using the Space or Enter keys

Status: RESOLVED FIXED

(Firefox :: Keyboard Navigation, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: 2022-08-12_11h29_52.mp4

Found in

• 105.0a1 (2022-08-11)

Affected versions

• Firefox Nightly 105.0a1
• Beta 104.0b9

Affected platforms

• all

Steps to reproduce

1. Open enough tabs for the List all tabs button to appear.
2. Reach the List all tabs button using keyboard navigation.
3. Use the Space or Enter keys in order to open the List all tabs Dropdown.

Expected result

• User should be able to open the list all tabs dropdown using keyboard navigation

Actual result

• The space or enter keys will not open the list all tabs dropdown.
  Please note that older versions than Beta will not allow the user to reach that button at all using keyboard navigation.

Comment 1

[Molly Howell (she/her) (mostly inactive)]

I can make this problem go away by reverting the change from bug 1489124.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1489124

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1489124

Comment 4

[:Gijs (he/him)]

bug 1786011 is going to make this worse by exposing this to everyone in 106.

Fixing this should be straightforward in principle.

Comment 5

[:Gijs (he/him)]

Attachment: Bug 1784432 - allow opening list all tabs menu using the keyboard, r?mhowell

Comment 6

[:Gijs (he/him)]

Comment on attachment 9292073 [details]
Bug 1784432 - allow opening list all tabs menu using the keyboard, r?mhowell

Beta/Release Uplift Approval Request

• User impact if declined: Can't use all tabs menu with the keyboard
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: N/A
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only adds a keyboard event handler to the existing button
• String changes made/needed: Nope
• Is Android affected?: No

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e511290b39cc
allow opening list all tabs menu using the keyboard, r=mhowell

Comment 8

[Sandor Molnar[:smolnar]]

Backed out changeset e511290b39cc (bug 1784432) for causing browser-chrome failures in browser/components/extensions/test/browser/browser_ext_menus_events.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8f1bc7aba07ecaee5762c62a28aa49fa90bec66a

Push with failures

Failure log

TEST-UNEXPECTED-FAIL | browser/components/extensions/test/browser/browser_ext_menus_events.js | Uncaught exception in test - at chrome://browser/content/browser-allTabsMenu.js:143 - TypeError: can't access property "type", event is undefined

Comment 9

[:Gijs (he/him)]

Hrmpf, people call this with a null event param. Ah well, I guess showSubView copes so this code should too...

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f1e69c9018d6
allow opening list all tabs menu using the keyboard, r=mhowell

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/f1e69c9018d6

Comment 12

[Rares Doghi, Desktop QA]

Verified as fixed in our latest build 106.0a1 (2022-08-30).

Comment 13

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9292073 [details]
Bug 1784432 - allow opening list all tabs menu using the keyboard, r?mhowell

Approved for 105.0b5.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/637d029dd611

Comment 15

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta build as well.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Did we want to take this on ESR102 also? It grafts cleanly.

Comment 18

[:Gijs (he/him)]

Comment on attachment 9292073 [details]
Bug 1784432 - allow opening list all tabs menu using the keyboard, r?mhowell

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: Accessibility issue with the all tabs menu
• User impact if declined: Can't open the menu with the keyboard
• Fix Landed on Version: 106, uplifted to 105
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): 3 lines of JS and a line of markup; has an automated test to check it works.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9292073 [details]
Bug 1784432 - allow opening list all tabs menu using the keyboard, r?mhowell

Approved for 102.3esr.

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/54a431be0bbe

Comment 21

[Rares Doghi, Desktop QA]

Hi, I tried to verify this issue in our latest ESR build 20220902190600 but there is no way for us to Reach the "List all tabs" button using Keyboard Navigation, Focus will jump from the last tab straight to the Back or Refresh buttons from the Toolbar.

Comment 22

[Molly Howell (she/her) (mostly inactive)]

I was able to get there by tabbing to the New Tab button and then using arrow keys to reach the tabs list button (on Windows, that method also gets you to the window controls). I don't know whether that's the intended behavior or not, it definitely seems a bit odd.

Comment 23

[Rares Doghi, Desktop QA]

Hi Molly, have you tried this in our latest ESR 102.3.0 ? because this is the only version where that doesnt work, I can reach the list all button using the same steps you did in all versions of Firefox except Esr 102.3.0 where the fix was uplifted.

Comment 24

[Molly Howell (she/her) (mostly inactive)]

Ah, yeah, you're right, there's another bug happening on ESR; sorry about that. I suspect the problem is that bug 1767802 is missing.

Comment 25

[:Gijs (he/him)]

(In reply to Molly Howell (she/her) [:mhowell] from comment #24)

Ah, yeah, you're right, there's another bug happening on ESR; sorry about that. I suspect the problem is that bug 1767802 is missing.

Given bug 1778450 I'm not convinced we want to uplift 1767802 to ESR at this time. Ryan, do we just want to mark esr wontfix, then? (The button can't be moved out of the tabstrip).

Comment 26

[Ryan VanderMeulen [:RyanVM]]

Yeah, let's backout.

Comment 27

[:Gijs (he/him)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #26)

Yeah, let's backout.

TBF I don't know if we need to back out from ESR - it probably won't do any harm? But up to you.

Comment 28

[Ryan VanderMeulen [:RyanVM]]

Discussed it with Gijs on Slack. I'm going to leave it in on the chance that there's other ways to focus the button beyond keyboard navigation since the risk to doing so is very low.