1489124 - Open all tabs popup on mouse down event instead of mouse up

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P3)

Description

[afnankhan]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0
Build ID: 20180905223809

Steps to reproduce:

Click on all tabs button.


Actual results:

All tabs popup opens after releasing the mouse button.


Expected results:

The popup should open on mouse down event. It feels slow compared to other popups. Most of the button in Firefox open on mouse down button.

Comment 1

[Kanchan Kumari QA]

It would be great if you could provide small test case for this bug, so that I can try to duplicate the issue. Meanwhile I am placing this under Core:Dom Events so someone can look into it. Thanks!

Comment 2

[afnankhan]

This bug is about "List all tabs" button which appears when the tab bar is full. To reproduce this bug open tabs until the tab bar is full and list all tabs button appears then click on the button. The tab list popup appears on mouse up. It should appear on mouse down and before mouse up similar to other buttons like hamburger menu and library button.

Comment 3

[afnankhan]

Attachment: List all tabs popup

Comment 4

[Kanchan Kumari QA]

Thanks for the STR! I was able to reproduce this on 

User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:64.0) Gecko/20100101 Firefox/64.0

User Agent 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:62.0) Gecko/20100101 Firefox/62.0

Comment 5

[Andreas Farre [:farre]]

There doesn't seem to be a consistency here for when buttons and menus should activate, but I think that this should be in the Tabbed Browser component to begin with.

Comment 6

[kz04px]

Attachment: Bug 1489124 - Open "List all tabs" button on mouse down. r?dao

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1446101

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/109ea9e3f1c0
Open "List all tabs" button on mouse down. r=dao

Comment 9

[Cristian Tuns]

Backed out for causing mochitest failures on browser_startup_images.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://global/skin/icons/arrow-right.svg should have been shown.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/646535a71f53
Open "List all tabs" button on mouse down. r=dao

Comment 11

[Iulian Moraru]

Backed out for causing mochitest failures on browser_startup_images.js.

Push with failures

Failure log

Backout link

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b68d4dc6cdfa
Open "List all tabs" button on mouse down. r=dao

Comment 13

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/b68d4dc6cdfa

Comment 14

[kz04px]

(In reply to Cristian Tuns from comment #9)

Backed out for causing mochitest failures on browser_startup_images.js

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_startup_images.js | Loaded image chrome://global/skin/icons/arrow-right.svg should have been shown.

The patch was redone in a different and simpler way that avoided the issue. Didn't diagnose what was actually going wrong because of this.

Comment 15

[Virgil Sangerean]

Reproduced with 2018-09-06-10-02-52 FF nightly.

On 97.0b9 on Windows 10, Ubuntu 20 and Mac, the list is shown at the click of the mouse, not on the release of the click.

Marked as verified.