1784524 - update macOS icons

Status: VERIFIED FIXED

(Firefox :: Shell Integration, enhancement, P2)

Description

[[e-mail] (:bhearsum)]

UX is in the process of creating new icons for Firefox on macOS. We'll need to update the firefox.icns files in the tree with the new versions.

These files appear to containing multiple versions of the Firefox logo at different sizes and DPIs, specifically:

• 1024x1024@144dpi
• 512x512@144dpi & 72dpi
• 256x256@144dpi & 72dpi
• 128x128@72dpi
• 64x64@144dpi
• 32x32@144dpi & 72dpi
• 16x16@72dpi

(This is per the "macOS app icon sizes" on Apple's HID Guidelines)

After some investigation, it looks like the easiest way to generate these is to start with a 1024x1024@144dpi PNG, and run the following to generate the others, and the ultimate icns:

mkdir MyIcon.iconset
sips -z 16 16     Icon1024.png --out MyIcon.iconset/icon_16x16.png
sips -z 32 32     Icon1024.png --out MyIcon.iconset/[e-mail]
sips -z 32 32     Icon1024.png --out MyIcon.iconset/icon_32x32.png
sips -z 64 64     Icon1024.png --out MyIcon.iconset/[e-mail]
sips -z 128 128   Icon1024.png --out MyIcon.iconset/icon_128x128.png
sips -z 256 256   Icon1024.png --out MyIcon.iconset/[e-mail]
sips -z 256 256   Icon1024.png --out MyIcon.iconset/icon_256x256.png
sips -z 512 512   Icon1024.png --out MyIcon.iconset/[e-mail]
sips -z 512 512   Icon1024.png --out MyIcon.iconset/icon_512x512.png
cp Icon1024.png MyIcon.iconset/[e-mail]
iconutil -c icns MyIcon.iconset

(This script is from this stackoverflow post).

The new logos we're looking at have a coloured background (instead of transparent), so we may also end up updating the DMG background images - this part is still TBD.

I'd also like to take this opportunity to make sure we have documentation on this for the future.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1784524: Add basic documentation around Firefox branding & updating macOS icons r?nalexander!

Although we do this updates fairly infrequently, these instructions seem like they'll be stable enough that it's worth writing them down.

Comment 2

[[e-mail] (:bhearsum)]

Attachment: Bug 1784524: update firefox macOS app icons. r?nalexander!

Note: this is awaiting final sign off from UX, and confirmation that we want to land it in 106

Depends on D155581

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bhearsum, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Comment 4

[[e-mail] (:bhearsum)]

(In reply to Release mgmt bot [:suhaib / :marco/ :calixte] from comment #3)

There are some r+ patches which didn't land and no activity in this bug for 2 weeks.
:bhearsum, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

This is waiting on approval from UX before it can be landed (we're still deciding which release cycle we want this in).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c69318c7dcf9
Add basic documentation around Firefox branding & updating macOS icons r=nalexander

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c69318c7dcf9

Comment 7

[[e-mail] (:bhearsum)]

Only the documentation bit landed here -- not the icons.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d4273702086
update firefox macOS app icons. r=nalexander

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5d4273702086

Comment 10

[[e-mail] (:bhearsum)]

Comment on attachment 9291543 [details]
Bug 1784524: update firefox macOS app icons. r?nalexander!

Beta/Release Uplift Approval Request

• User impact if declined: Users will have old style rounded macOS icons instead of square ones with a solid background.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1) Install mac build

2. Put it in the Dock
3. Ensure the icon is a Firefox icon with a solid background (rather than a logo on a transparent one)

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This patch only touches icon files on macOS.
• String changes made/needed: no
• Is Android affected?: No

Comment 11

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9291542 [details]
Bug 1784524: Add basic documentation around Firefox branding & updating macOS icons r?nalexander!

This one landed in 106 already.

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9291543 [details]
Bug 1784524: update firefox macOS app icons. r?nalexander!

Approved for 106.0b3, thanks.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

https://hg.mozilla.org/releases/mozilla-beta/rev/d81edafde92a

Comment 14

[Hsiao-Ting Yu (Littlebtc)]

Found this after icon changes. I think this will also close Bug 1648386?

Comment 15

[valord577]

Firefox icon is smaller than others.

Image here: https://imgur.com/a/YpsqzF0

Comment 16

[Vlad Lucaci, Desktop QA (:vlucaci)]

Hello,

Confirming this issue as verified fixed.

Verification was done on the following configurations:

• macOS 13 (beta4)
• macOS 12.5.1
• macOS 11.6.8
• macOS 10.15.7

With the following builds:

• 107.0a1(20220922214429)
• 106.0b3(20220922185808) - DevEdition included

Comment 18

[Mehmet]

Unfortunately, this change feels like a regression. I filed a new report for it: Bug 1792247