1784876 - [Wayland] Library menu flickering on close

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P3)

Description

[Martin Stránský [:stransky] (ni? me)]

Attachment: Screencast from 08-15-2022 02:42:12 PM.webm

Library menu is flickering on close.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

It's because the panel popup is always created as a new window and when we pile them up (we open a new popup while the old one is still open) the anchor calculation is wrong - the underlying popup is shifted by move-to-rect call.

Not sure why we fail to close the popup after second mouse click.

EDIT: That's also reason why we can't close the previous popup - according to layout the two popups is correct setup.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Emilio, can you help me to debug this? Any idea why it's new popup opened when we expect close of the previous one?
Thanks.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

It happens when library icon is moved to left and move-to-rect is used. When move-to-rect is disabled (at about:config) it works as expected. I wonder if it's related to anchor config or so.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Can it be related to wrong anchor (or something different) stored at nsMenuPopupFrame ?
I wonder if we return wrong info to content so content opens another popup instead of closing the existing one.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1784876 - Fix rollup code for moved-to-rect popups. r=stransky

When we move-to-rect we call nsMenuPopupFrame::MoveTo, which causes our
anchor type to be a point. However, we still want to check the original
anchor node for rollups (the button in this case).

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2f18062042c8
Fix rollup code for moved-to-rect popups. r=stransky

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2f18062042c8

Comment 8

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I tried reproducing this issue on Ubuntu 22.04 on a 2022-08-15 Nightly build in a Wayland session without success.
I have widget.wayland.use-move-to-rect set to true, layout.css.devPixelsPerPx to -1.0. Are there any other tweaks I need to configure in order to reproduce?
Thanks.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

No need to verify this one.

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Thank you. I shall remove the qe-verify based on Comment 9.