Closed Bug 1784947 Opened 2 years ago Closed 2 years ago

convert browser action to a custom CUI widget

Categories

(WebExtensions :: Frontend, enhancement, P2)

enhancement

Tracking

(firefox108 fixed)

RESOLVED FIXED
108 Branch
Tracking Status
firefox108 --- fixed

People

(Reporter: mixedpuppy, Assigned: willdurand)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

No description provided.
Assignee: nobody → mixedpuppy
Status: NEW → ASSIGNED
Blocks: 1777484
Assignee: mixedpuppy → wdurand
Attachment #9289940 - Attachment description: Bug 1784947 make browser action a custom widget to support unified extension button → Bug 1784947 - Make browser action a custom widget to support unified extension button. r?mixedpuppy,dao
Attachment #9289940 - Attachment description: Bug 1784947 - Make browser action a custom widget to support unified extension button. r?mixedpuppy,dao → Bug 1784947 - Make browser action a custom widget to support unified extension button. r?zombie!
Pushed by wdurand@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9ccf7e4ee23d Make browser action a custom widget to support unified extension button. r=desktop-theme-reviewers,zombie,Itiel
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 108 Branch
Regressions: 1799143

These seem to be missing the usual 2px padding between buttons due to .toolbaritem-combined-buttons style.

toolbar .toolbarbutton-1 {
  appearance: none;
  margin: 0;
  padding: 0 var(--toolbarbutton-outer-padding);
  -moz-box-pack: center;
}
toolbar .toolbaritem-combined-buttons > .toolbarbutton-1 {
  padding-inline: 0;
}

maybe add this?

toolbar .toolbaritem-combined-buttons.unified-extensions-item {
  padding: 0 var(--toolbarbutton-outer-padding);
}
Depends on: 1799331
Regressions: 1802411
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: