Update sub-dialog dimensions now that they're based on the sub-dialog's real font size
Categories
(Firefox :: Settings UI, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox-esr102 | --- | unaffected |
| firefox103 | --- | unaffected |
| firefox104 | --- | unaffected |
| firefox105 | --- | fixed |
People
(Reporter: dao, Assigned: dao)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-colorway-closet])
Attachments
(1 file)
From https://phabricator.services.mozilla.com/D154775#5076141:
[...] bug 1784488 regressed font size on dialogs in about:preferences, and is now too big for a relatively small frame. Was that intentional?
I think what's happening here is that stuff like: https://searchfox.org/mozilla-central/rev/f3616b887b8627d8ad841bb1a11138ed658206c5/browser/locales/en-US/browser/preferences/colors.ftl#7-11
... now correctly uses the sub-dialog's font size, rather than the random thing we were doing before. We'll probably have to adjust these em values.
|
||
Updated•2 years ago
|
|
||
Comment 1•2 years ago
|
||
Set release status flags based on info from the regressing bug 1784488
|
Assignee | |
Comment 2•2 years ago
|
||
So I checked all dialogs I could find based on https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/preferences, and I think we're mostly good, but I do want to update colors.ftl which has obsolete platform differences baked in.
|
|
Assignee | |
Comment 3•2 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/48f451d02ab5 Consolidate sub-dialog title bar styling and update Colors dialog default width. r=Itiel,fluent-reviewers,flod
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•