1785203 - Update sub-dialog dimensions now that they're based on the sub-dialog's real font size

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Dão Gottwald [:dao]]

From https://phabricator.services.mozilla.com/D154775#5076141:

[...] bug 1784488 regressed font size on dialogs in about:preferences, and is now too big for a relatively small frame. Was that intentional?

I think what's happening here is that stuff like: https://searchfox.org/mozilla-central/rev/f3616b887b8627d8ad841bb1a11138ed658206c5/browser/locales/en-US/browser/preferences/colors.ftl#7-11
... now correctly uses the sub-dialog's font size, rather than the random thing we were doing before. We'll probably have to adjust these em values.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784488

Comment 2

[Dão Gottwald [:dao]]

So I checked all dialogs I could find based on https://searchfox.org/mozilla-central/source/browser/locales/en-US/browser/preferences, and I think we're mostly good, but I do want to update colors.ftl which has obsolete platform differences baked in.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1785203 - Consolidate sub-dialog title bar styling and update Colors dialog default width. r=Itiel

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48f451d02ab5
Consolidate sub-dialog title bar styling and update Colors dialog default width. r=Itiel,fluent-reviewers,flod

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/48f451d02ab5