Closed Bug 1785205 Opened 2 years ago Closed 2 years ago

font size of about:certificate and about:studies regressed

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

VERIFIED FIXED
106 Branch
Tracking Status
firefox-esr91 --- unaffected
firefox-esr102 --- unaffected
firefox103 --- unaffected
firefox104 --- unaffected
firefox105 + verified
firefox106 --- verified

People

(Reporter: soeren.hentzschel, Assigned: dao)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Bug 1784488 regressed the font size of about:certificate and about:studies. On about:certificate the tab titles are noticeable larger, on about:studies everything is really large now. Tested on macOS 12.5.

Flags: needinfo?(dao+bmo)

Set release status flags based on info from the regressing bug 1784488

Set release status flags based on info from the regressing bug 1784488

This is a regression in our next release, can we get this bug triaged and assigned if we don't want this regression in 105? Thanks

Hi Chris, is this something we can get a fix for before 105 RC in a couple weeks? Thanks!

Flags: needinfo?(cbellini)

The bug is marked as tracked for firefox105 (beta). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Flags: needinfo?(cbellini)
Assignee: nobody → dao+bmo
Flags: needinfo?(cbellini)

So this is mostly intentional in terms of getting font sizes for our about:pages to be consistent. However there's this line increasing the font size for about:studies that we need to remove: https://searchfox.org/mozilla-central/rev/fa81b64fc1a339e2b2b1f6a8637a689916e13c4e/toolkit/components/normandy/content/about-studies/about-studies.css#30

Flags: needinfo?(dao+bmo)
Severity: -- → S4
Priority: -- → P3
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/136f13b75057
Stop increasing the font size for about:studies. r=Itiel
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Comment on attachment 9292686 [details]
Bug 1785205 - Stop increasing the font size for about:studies. r=Itiel

Beta/Release Uplift Approval Request

  • User impact if declined: about:studies has oversized text. It's a polish issue given that the page works fine as-is, but it does look odd. Note that we link to about:studies from about:preferences, so some users would likely run into this.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Open both about:studies and about:preferences and roughly compare the font sizes
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): trivial CSS patch
  • String changes made/needed:
  • Is Android affected?: No
Attachment #9292686 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Blocks: 1788898

Comment on attachment 9292827 [details]
Bug 1785205 - Stop increasing the font size for about:certificate tabs too much r?dao,gijs

Revision D156295 was moved to bug 1788898. Setting attachment 9292827 [details] to obsolete.

Attachment #9292827 - Attachment is obsolete: true

Comment on attachment 9292686 [details]
Bug 1785205 - Stop increasing the font size for about:studies. r=Itiel

Approved for 105.0b7.

Attachment #9292686 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [qa-triaged]

Verified as fixed in our latest beta 105.0b7 and our latest Nightly 106.0a1 (2022-09-04).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
QA Whiteboard: [qa-triaged]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: