1785205 - font size of about:certificate and about:studies regressed

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P3)

Description

[Sören Hentzschel]

Bug 1784488 regressed the font size of about:certificate and about:studies. On about:certificate the tab titles are noticeable larger, on about:studies everything is really large now. Tested on macOS 12.5.

Comment 1

[Sören Hentzschel]

Attachment: comparison of about:studies

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784488

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1784488

Comment 4

[Pascal Chevrel:pascalc]

This is a regression in our next release, can we get this bug triaged and assigned if we don't want this regression in 105? Thanks

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Hi Chris, is this something we can get a fix for before 105 RC in a couple weeks? Thanks!

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox105 (beta). However, the bug still isn't assigned.

:cbellini, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit auto_nag documentation.

Comment 7

[Dão Gottwald [:dao]]

So this is mostly intentional in terms of getting font sizes for our about:pages to be consistent. However there's this line increasing the font size for about:studies that we need to remove: https://searchfox.org/mozilla-central/rev/fa81b64fc1a339e2b2b1f6a8637a689916e13c4e/toolkit/components/normandy/content/about-studies/about-studies.css#30

Comment 8

[Dão Gottwald [:dao]]

Attachment: Bug 1785205 - Stop increasing the font size for about:studies. r=Itiel

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/136f13b75057
Stop increasing the font size for about:studies. r=Itiel

Comment 10

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/136f13b75057

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 9292686 [details]
Bug 1785205 - Stop increasing the font size for about:studies. r=Itiel

Beta/Release Uplift Approval Request

• User impact if declined: about:studies has oversized text. It's a polish issue given that the page works fine as-is, but it does look odd. Note that we link to about:studies from about:preferences, so some users would likely run into this.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Open both about:studies and about:preferences and roughly compare the font sizes
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): trivial CSS patch
• String changes made/needed:
• Is Android affected?: No

Comment 12

[Itiel]

Attachment: Bug 1785205 - Stop increasing the font size for about:certificate tabs too much r?dao,gijs

Comment 13

[Phabricator Automation]

Comment on attachment 9292827 [details]
Bug 1785205 - Stop increasing the font size for about:certificate tabs too much r?dao,gijs

Revision D156295 was moved to bug 1788898. Setting attachment 9292827 [details] to obsolete.

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9292686 [details]
Bug 1785205 - Stop increasing the font size for about:studies. r=Itiel

Approved for 105.0b7.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2dbba09ddbc8

Comment 16

[Rares Doghi, Desktop QA]

Verified as fixed in our latest beta 105.0b7 and our latest Nightly 106.0a1 (2022-09-04).