1785277 - Add source actor information to the location

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Hubert Boma Manilla (:bomsy)]

Lets start tracking source actor id as part of the location information here https://searchfox.org/mozilla-central/rev/f3616b887b8627d8ad841bb1a11138ed658206c5/devtools/client/debugger/src/utils/location.js#12-22. This will help with tracking the specific source actor which loads the source text when a location is selected. A source can have multiple source actors, at the moment the is no guarantee that the correct source actor is selected. The https://searchfox.org/mozilla-central/rev/f3616b887b8627d8ad841bb1a11138ed658206c5/devtools/client/debugger/test/mochitest/browser_dbg-features-source-text-content.js covers this issue.

Comment 1

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1785277 - Load source text with source actor r=

Comment 3

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1785277 - Use source actor select location (WIP)

Depends on D154778

Comment 4

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1785277 - [devtools] Add sourceActorId to location r=ochameau

Depends on D154778

Comment 5

[Phabricator Automation]

Comment on attachment 9290415 [details]
Bug 1785277 - Load source text with source actor r=

Revision D154778 was moved to bug 1787198. Setting attachment 9290415 [details] to obsolete.

Comment 6

[Hubert Boma Manilla (:bomsy)]

Attachment: Bug 1785277 - [devtools] Caching the sourceActorId with the symbols

Depends on D155952

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b7cdb0cf84b6
[devtools] Add sourceActorId to location r=ochameau

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/b7cdb0cf84b6

Comment 9

[Marian-Vasile Laza]

Backed out changeset b7cdb0cf84b6 (Bug 1785277) for causing devtools failures on browser_dbg-quick-open.js.
Backout link
Push with failures
Failure Log

Comment 10

[Marian-Vasile Laza]

Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/2a6d0d508c36ef75c300010c520504d274a7f36b

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d1982cee06ca
[devtools] Add sourceActorId to location r=ochameau

Comment 12

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/d1982cee06ca

Comment 13

[Julian Descottes [:jdescottes]]

== Change summary for alert #35745 (as of Tue, 25 Oct 2022 16:09:31 GMT) ==

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
65%	damp custom.jsdebugger.project-search.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	909.23 -> 1,504.61
63%	damp custom.jsdebugger.project-search.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	934.05 -> 1,525.95
61%	damp custom.jsdebugger.project-search.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	1,028.35 -> 1,654.38
60%	damp custom.jsdebugger.project-search.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender	1,021.36 -> 1,633.52
52%	damp custom.jsdebugger.project-search.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	937.62 -> 1,420.65
51%	damp custom.jsdebugger.project-search.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	992.63 -> 1,498.82
40%	damp custom.jsdebugger.stepOver.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	277.76 -> 389.27
29%	damp custom.jsdebugger.stepOver.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	288.55 -> 372.13
25%	damp custom.jsdebugger.stepOver.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	356.48 -> 447.25
23%	damp browser-toolbox.debugger-ready.DAMP	macosx1015-64-shippable-qr	e10s fission stylo webrender-sw	815.24 -> 1,005.76
...	...	...	...	...
6%	damp custom.jsdebugger.stepOut.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	535.29 -> 567.42
5%	damp custom.jsdebugger.stepOut.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender	462.82 -> 483.99
4%	damp browser-toolbox.webconsole-ready.DAMP	linux1804-64-shippable-qr	e10s fission stylo webrender	422.56 -> 439.70
4%	damp custom.jsdebugger.stepOut.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	463.97 -> 482.40
4%	damp custom.jsdebugger.stepIn.DAMP	windows10-64-shippable-qr	e10s fission stylo webrender-sw	637.93 -> 661.26

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=35745

Comment 14

[Julian Descottes [:jdescottes]]

Hubert, Alex, do we want to investigate/fix the regression detected by DAMP for this change (see previous comment)? If yes, can you file a follow up?

Comment 15

[Hubert Boma Manilla (:bomsy)]

Oh thanks,
This might relate to now always getting the source actor anytime we need to load the source text.
There are likely going to regressions with moving to breakpoints per url, but maybe i can improve this a little bit here e.g The source is always selected again using the id where instead we could just pass the source in directly here. Maybe that helps, i'll check and file

Comment 16

[Alexandre Poirot [:ochameau]]

The regressions around custom.jsdebugger.project-search are concerning and should be investigated.
We might have significantly slow down file search, which is a nice thing being fast in firefox (while being super slow in chrome).