1785366 - Add blocklist support for backdrop filter

Status: RESOLVED FIXED

(Core :: Graphics, defect, P3)

Description

[Andrew Osmond [:aosmond] (he/him)]

As seen in bug 1784093, we need to support blocklisting backdrop filter on some drivers. The alternative would be to take away hardware acceleration from these users, but it is probably more valuable to keep that and take away backdrop filter.

Comment 1

[Andrew Osmond [:aosmond] (he/him)]

Attachment: Bug 1785366 - Blocklist backdrop filter on some Ivy/Sandybridge Intel Windows drivers.

Backdrop filter crashes newer Intel drivers on Windows. This patch adds
support to the blocklist infrastructure for backdrop filter, and hooks
this up with the CSS property table.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49c7536f01db
Blocklist backdrop filter on some Ivy/Sandybridge Intel Windows drivers. r=jrmuizel,emilio

Comment 3

[Marian-Vasile Laza]

Backed out changeset 49c7536f01db (Bug 1785366) for causing xpcshell failures on test_css-properties-db.js.
Backout link
Push with failures <--> x1
Failure Log

Comment 4

[Andrew Osmond [:aosmond] (he/him)]

The CSS properties DB really should not have changed. I believe it did because the default for the gfxVar was false, instead of true, and the generation of the database is done without initializing gfx.

Comment 5

[Andrew Osmond [:aosmond] (he/him)]

green try run: https://treeherder.mozilla.org/jobs?repo=try&revision=d472d44a1ac15109c824fd1c2611f3132e001bce

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/212f3aa67402
Blocklist backdrop filter on some Ivy/Sandybridge Intel Windows drivers. r=jrmuizel,emilio

Comment 7

[Andrew Osmond [:aosmond] (he/him)]

Comment on attachment 9290380 [details]
Bug 1785366 - Blocklist backdrop filter on some Ivy/Sandybridge Intel Windows drivers.

Beta/Release Uplift Approval Request

• User impact if declined: Users with certain GPUs and drivers will experience a driver crash when browsing to a site with a backdrop filter. This impacts something like 6-8% of our population.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: On any Windows computer with an Ivybridge or Sandybridge GPU, confirm that we render/do not render CSS backdrop filter, i.e. https://developer.mozilla.org/en-US/docs/Web/CSS/backdrop-filter.

1. If the driver is > 8.15.10.2879 and < 10.18.10.4425, then by default elements using CSS backdrop filter should not render.
2. If the driver is <= 8.15.10.2879 or >= 10.18.10.4425, then by default elements using CSS backdrop filter should render.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This uses a combination of the blocklist, which is well tested, and a means to change how CSS properties are exposed, which was tested by non-WebRender users to disable backdrop filter during our roll out since only our WR implementation supports it.
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9290380 [details]
Bug 1785366 - Blocklist backdrop filter on some Ivy/Sandybridge Intel Windows drivers.

Approved for 104.0rc3

Comment 9

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-release/rev/ae56b3bb7fa3

Comment 10

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/212f3aa67402

Comment 11

[Daniel Bodea [:danibodea]]

We have attempted to reproduce this issue on our systems that have Intel GPUs, however, we could not find one that does. Furthermore, installing and uninstalling drivers can not be done on company systems without admin credentials.

We can't properly verify this fix with the available resources. Could someone who consistently reproduces it also verify the fix? (Maybe Jeff Muizelaar?) Thanks!

Comment 12

[Jeff Muizelaar [:jrmuizel]]

I've verified the fix for me locally

Comment 13

[Mihai Boldan, Desktop QA [:mboldan]]

Removing the qe+ flag since the issue could not be reproducible on our side and the fix was confirmed by Jeff in Comment 12.