1785412 - Ship ARIA reflection (non-idref)

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Thomas Wisniewski [:twisniewski]]

According to MDN, Firefox does not support the ariaSelected property. This appears to be causing webcompat issues, including on an Indian government site (uucms.karnataka.gov.in), where clicking on the "student" radio button on their login page does not work properly due to their code checking for ariaSelected on anchor elements representing tabs in their UI (this was originally reported at https://webcompat.com/issues/108532).

Comment 1

[Emilio Cobos Álvarez (:emilio)]

What's the status of the ARIA attribute reflection stuff (I assume this is it?)

Apparently accessibility.ARIAReflection.enabled enables this.

Comment 2

[James Teh [:Jamie]]

See bug 1628418 comment 24.

Comment 3

[James Teh [:Jamie]]

I'm morphing this into a bug to track shipping of ARIA reflection, since that's ultimately what this is about and we don't have one already.

Comment 6

[Ksenia Berezina [:ksenia] on leave until 09/15]

This is affecting dropdowns for the main menu on rottentomatoes.com (they're using element.ariaExpanded = "true")

Comment 7

[Nolan Lawson]

Just to check – does this comment from James Teh still describe Mozilla's position on ARIA non-idref reflection? I.e. is implementation blocked on the spec issues aria#1110 and aria#1239?

Comment 8

[James Teh [:Jamie]]

It's definitely still blocked on ARIA#1110. I need to check with DOM colleagues about ARIA#1239.

Comment 10

[James Teh [:Jamie]]

(In reply to James Teh [:Jamie] from comment #8)

I need to check with DOM colleagues about ARIA#1239.

We agreed that this is not a blocker for us.

Comment 11

[Sebastian Zartner [:sebo]]

This needs to be documented in the browser compat data (and be removed from https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features if documented there for bug 1824980).

Sebastian

Comment 15

[Luke Warlow]

I see this has an intent to ship what was the conclusion to https://github.com/w3c/aria/issues/1110

Will firefox be matching Chrome and Safari or will it be different?

Comment 16

[James Teh [:Jamie]]

For pragmatic reasons, we will ship matching Chrome and Safari to maximise web compat. If we can get consensus on a change across the board, we'll likely try to follow. Pragmatically, though, I think this ship has probably sailed. The priority right now is to stop the web compat pain.

Comment 17

[James Teh [:Jamie]]

Attachment: Bug 1785412: Let ARIA reflection (non-idref) and default Accessibility Semantics for Custom Elements ride the trains.

Comment 18

[James Teh [:Jamie]]

Intent to ship: https://groups.google.com/a/mozilla.org/g/dev-platform/c/1IvZq_uK9Ho

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5f5a3f190fdf
Let ARIA reflection (non-idref) and default Accessibility Semantics for Custom Elements ride the trains. r=eeejay

Comment 20

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5f5a3f190fdf

Comment 21

[Donal Meehan [:dmeehan]]

:jamie could you please consider nominating this for a relnote? https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Comment 22

[James Teh [:Jamie]]

Thanks. Shall do. That wiki page has this to say:

Note that most of the changes impacting web developers (tooling, web standard support, and new technologies) are documented on MDN which has specific pages for releases aimed at developers. The MDN team tracks these bugs with the dev-doc-needed keyword.

That could be construed as meaning that we shouldn't nominate web platform features, etc. for release notes because MDN is the more appropriate place. It might be worth clarifying the wiki page to avoid confusion here.

Comment 23

[James Teh [:Jamie]]

Release Note Request (optional, but appreciated)
[Why is this notable]: New web platform feature which fixes a significant web compat issue.
[Affects Firefox for Android]: Yes.
[Suggested wording]: Web Platform: ARIA reflection for simple attributes and default Accessibility Semantics for Custom Elements are now supported. Note that this includes boolean, enum, number and string attributes, but not attributes which reference other elements.
[Links (documentation, blog post, etc)]: https://developer.mozilla.org/en-US/docs/Web/API/Element#instance_properties_included_from_aria https://developer.mozilla.org/en-US/docs/Web/API/ElementInternals#instance_properties_included_from_aria

Comment 24

[James Teh [:Jamie]]

Note for MDN: This will require updates to all ARIA properties on Element and all ARIA properties on ElementInternals, as well as the Experimental Features in Firefox page.

Comment 25

[Sebastian Zartner [:sebo]]

(In reply to James Teh [:Jamie] from comment #22)

Thanks. Shall do. That wiki page has this to say:

Note that most of the changes impacting web developers (tooling, web standard support, and new technologies) are documented on MDN which has specific pages for releases aimed at developers. The MDN team tracks these bugs with the dev-doc-needed keyword.

That could be construed as meaning that we shouldn't nominate web platform features, etc. for release notes because MDN is the more appropriate place. It might be worth clarifying the wiki page to avoid confusion here.

While we're at it, maybe someone could also clarify that implementers should also add the dev-doc-needed flag when the change is facing web developers, especially new features. And also they should add it when a new feature is implemented behind a flag and name the flag, so the MDN team knows that it needs to add it to the Experimental Features in Firefox.

Sebastian

Comment 26

[Donal Meehan [:dmeehan]]

Thanks, added a note to the Fx119 Nightly release notes. Keeping the relnote? flag open to keep it on the radar for inclusion in our final release notes.

Side note: Tweaked the wording of https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination based on Comment 22 and Comment 25.