1824980 - Enable ARIA reflection (non-idref) on Nightly

Status: RESOLVED FIXED

(Core :: Disability Access APIs, task)

Description

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Jamie and I talked on slack that we think it makes sense to enable this feature on Nightly. This will help us easily track the remainder work for interop-2023 and gather user feedback in the wild, so we can start to move on gradually and hopefully prepare for the final release, especially given that there seems to be good progress on the spec issue https://github.com/w3c/aria/issues/1110 .

Comment 1

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Hi Jamie, would you like to submit a patch for this?

Comment 2

[James Teh [:Jamie]]

Sure. Do you know whether I need to make any changes with regard to WPT to enable those tests or the like?

Comment 3

[James Teh [:Jamie]]

Attachment: Bug 1824980: Enable ARIA reflection (non-idref) on Nightly.

Comment 4

[Hsin-Yi Tsai (she/her)[:hsinyi]]

(In reply to James Teh [:Jamie] (away returning 12 April) from comment #2)

Sure. Do you know whether I need to make any changes with regard to WPT to enable those tests or the like?

We talked on slack. Since our plan is to enable the feature on all nightly builds (not targeting on specific testing builds), we should proceed as normal feature flipping on nightly, no wpt pref in this case.

Comment 5

[Sebastian Zartner [:sebo]]

This should be documented at https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Experimental_features.

Sebastian

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2200dc940cc1
Enable ARIA reflection (non-idref) on Nightly. r=eeejay

Comment 7

[Cosmin Sabou [:CosminS]]

Backed out for causing aria releated wpt unexpected passes.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&selectedTaskRun=HHx2KHEdQhmDJ4n5-XkIqw.0&resultStatus=testfailed%2Cbusted%2Cexception&revision=2200dc940cc1cea9914e51a7aa7cd31f1531c74e&searchStr=wpt

Failure logs:

• https://treeherder.mozilla.org/logviewer?job_id=412134156&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=412133383&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=412133137&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/91a683d6d8cdcdb5cf03b13a4f0a62f1dd8c8eb4

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9094464c9ddc
Enable ARIA reflection (non-idref) on Nightly. r=eeejay

Comment 9

[Cristina Horotan [:chorotan]]

Backed out changeset 9094464c9ddc (bug 1824980) for causing wpt failures at idlharness.window.html and ElementInternals-accessibility.html

Backout: https://hg.mozilla.org/integration/autoland/rev/a18c543611cbc4c9aaaeb52f050128dd53a1ae62

Failure push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=9094464c9ddc2a1211e9f2c820c3705979424acc&selectedTaskRun=WkWe8VqaSeOgPxJH3NmV7g.0

Failure logs:
https://treeherder.mozilla.org/logviewer?job_id=412271508&repo=autoland&lineNumber=7386
https://treeherder.mozilla.org/logviewer?job_id=412267906&repo=autoland&lineNumber=2825

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/305f5743f591
Enable ARIA reflection (non-idref) on Nightly. r=eeejay

Comment 11

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/305f5743f591

Comment 12

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Thank you, Jamie!

Comment 13

[Brian Thomas Smith [:bsmth]]

Documentation changes for this can be tracked in the following GitHub issue: https://github.com/mdn/content/issues/26689