Closed Bug 1785757 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35507 - [css-flex] New intrinsic width algorithm for row wrap flexboxes

Categories

(Core :: Layout: Flexbox, task, P4)

task

Tracking

()

RESOLVED FIXED
107 Branch
Tracking Status
firefox107 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35507 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35507
Details from upstream follow.

David Grogan <dgrogan@chromium.org> wrote:

[css-flex] New intrinsic width algorithm for row wrap flexboxes

max-content size is same as for row no-wrap flexboxes, but min-content
is different. So we reuse the single line algorithm with a few
modifications for min-content.

row wrap necessitated more changes to existing tests than any of the
previous container types. You can see them over at
https://chromium-review.googlesource.com/c/chromium/src/+/3733177/2

Bug: 240765
Change-Id: Id6b56c2b4a77e5e30de88f0c3febdbc1a1cba4c8

Reviewed-on: https://chromium-review.googlesource.com/3834813
WPT-Export-Revision: cfbda98c458c0369f6a05dd426aa0ebc94e6dffa

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 5 subtests

Status Summary

Firefox

OK : 1
PASS: 1
FAIL: 4

Chrome

OK : 1
PASS: 1
FAIL: 4

Safari

OK : 1
PASS: 1
FAIL: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

  • /css/css-flexbox/intrinsic-size/row-wrap-001.html [wpt.fyi]
    • .floating-flexbox 1: FAIL (Chrome: FAIL, Safari: FAIL)
    • .floating-flexbox 2: FAIL (Chrome: FAIL, Safari: FAIL)
    • .floating-flexbox 4: FAIL (Chrome: FAIL, Safari: FAIL)
    • .floating-flexbox 5: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/70472af99f1f [wpt PR 35507] - [css-flex] New intrinsic width algorithm for row wrap flexboxes, a=testonly https://hg.mozilla.org/integration/autoland/rev/6f50bcf9f31d [wpt PR 35507] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.