1786324 - Change the way SearchService references engines from names to referencing an engine by ID

Status: VERIFIED FIXED

(Firefox :: Search, task, P2)

Description

[Mandy Cheang [:mcheang][she/her]]

We want to change the this._engines map within SearchService to use id as keys rather than engine names as keys.

Using Engine ids are preferred. There have been problems in the past where the engine name has been updated from the webextension and we needed to delete the engine and re-add it, see here: https://searchfox.org/mozilla-central/rev/9cd1e8cabf67ef5a47e95d70b7f40c9d3ad02ad0/toolkit/components/search/SearchService.sys.mjs#1918-1920

Comment 1

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1786324 - Change SearchService to reference engines by Ids rather than names. r?Standard8

names. r?Standard8

An uuid is created for every new instance of a SearchEngine. The new
getEngineById method should be called to return an engine rather than
calling getEngineByName.

Comment 2

[Mandy Cheang [:mcheang][she/her]]

Attachment: Bug 1786324 - Add migration for engine ids to be saved on user settings.r?Standard8

r?Standard8

Depends on D155236

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aac389dbe3cb
Change SearchService to reference engines by Ids rather than names. r=Standard8
https://hg.mozilla.org/integration/autoland/rev/a3d2ad0b9d00
Add migration for engine ids to be saved on user settings.r=Standard8

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/aac389dbe3cb
https://hg.mozilla.org/mozilla-central/rev/a3d2ad0b9d00

Comment 5

[Adrian Florinescu [:aflorinescu]]

Verified as fixed during the Nightly 108 Search Regression test run. Marking as such.