1805883 - Default search engine may be reset when upgrading to 108 if profile was previously copied

Status: VERIFIED FIXED

(Firefox :: Search, defect, P1)

Description

[Mark Banner (:standard8)]

STR

1. Use a Firefox version prior to 108
2. Set the default engine to an application provided one that is not the default engine.
3. Shutdown Firefox.
4. Create a new profile, and copy the search.json.mozlz4 file into that profile.

• Note: SUMO suggests to copy the profile when moving to a new computer.
• Users may also simply copy the file to copy their search settings.

1. Startup Firefox with the new profile.
2. Upgrade Firefox to version 108.

Expected Results

=> The default search engine set in step 2 is retained.

Actual Results

=> The default search engine is reset to the application default (typically Google).

Comment 1

[Mark Banner (:standard8)]

The issue here is that we have some protection in place for against changing the default engine from outside of Firefox. When loading Firefox, if an application provided engine is default we allow the protection to be ignored.

However, we missed accounting for that case in the migration added in bug 1786324.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1786324

Comment 3

[Mark Banner (:standard8)]

[Tracking Requested - why for this release]: Affects users upgrading to 108.

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 1805883 - Default search engine may be reset when upgrading to 108 if profile was previously copied. r?#search-reviewers!

Comment 5

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=a4587f8e7a176c85f32b7e06f2984def4bb01a45

Comment 6

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using the provided try-build and following the steps in the description. After doing to the upgrade to the try-build, the engine no longer changes (still the same engine used before the upgrade). This was verified on both Windows 10 and Ubuntu 22 using the pave-over method (copying the trybuild over the original install files).

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 9308496 [details]
Bug 1805883 - Default search engine may be reset when upgrading to 108 if profile was previously copied. r?#search-reviewers!

Beta/Release Uplift Approval Request

• User impact if declined: Users may have their default search engine reset to the application default when upgrading Firefox. This would only occur if they were using a profile that was previously copied.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See comment 0
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Added an additional simple check to cover this case based on existing code. Code has automated tests.
• String changes made/needed: None
• Is Android affected?: No

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/488d9d67cf0c
Default search engine may be reset when upgrading to 108 if profile was previously copied. r=search-reviewers,daleharvey,mcheang

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9308496 [details]
Bug 1805883 - Default search engine may be reset when upgrading to 108 if profile was previously copied. r?#search-reviewers!

Approved for 109.0b3 and 108.0.1.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e463347165d6

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/eebe28618896

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/488d9d67cf0c

Comment 13

[Cristian Baica [:cbaica], Release Desktop QA]

The issue is verified fixed using Fx110.0a1, Fx108.0.1 and Fx109.0b3 on Windows 10, Ubuntu 22.04 and macOS. The default engine is no longer reset after the upgrade is performed if the previous profile was copied.

Comment 14

[Adrian Florinescu [:aflorinescu]]

Regression tests added in the addressbar suite.