178643 - Remove uses of NS_INIT_ISUPPORTS from tree

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P4)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 174225 made NS_INIT_ISUPPORTS do nothing and deprecated it.  We should
remove the callers from the tree, although probably we should wait until the 1.0
branch is used less.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: moving the macro to nsISupportsObsolete.h

This moves NS_INIT_ISUPPORTS to nsISupportsObsolete.h.	This might require
changes to the commercial tree before it is checked in since
nsISupportsObsolete.h is not included in many files.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: treewide change

This is a gzipped patch.  It was created using the files
replacer.sed:
-----
/^[	]*NS_INIT_ISUPPORTS[	]*([	]*);\?[ 	]*$/d
s/NS_INIT_ISUPPORTS[	]*([	]*);\?[ 	]*//
-----
replacer sh:
-----
(find mozilla -name "*".cpp; find mozilla -name "*".h) | while read FILENAME;
do  sed -f replacer.sed $FILENAME > $FILENAME.replacer.$$.tmp
  if diff $FILENAME $FILENAME.replacer.$$.tmp >& /dev/null; then
    rm $FILENAME.replacer.$$.tmp
  else
    echo $FILENAME
    mv $FILENAME.replacer.$$.tmp $FILENAME
  fi
done
-----
And then undoing the changes they made to the two files in the previous patch. 
Note that everything between [] in the sed script is a space followed by a tab.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 110632 [details]
treewide change

Requesting r and sr.  I'm not expecting you to read every line... :-)

Comment 4

[jag (Peter Annema)]

Comment on attachment 110630 [details] [diff] [review]
moving the macro to nsISupportsObsolete.h

sr=jag

Comment 5

[jag (Peter Annema)]

Comment on attachment 110632 [details]
treewide change

sr=jag

Comment 6

[timeless]

Attachment: treewide change w/ minor changes

ok. this is fine, but i have a few minor things i wanted fixed so here's a
replacement patch, and the list of files i changed:

Index: mozilla/intl/ctl/src/nsULE.cpp
Index: mozilla/intl/lwbrk/public/nsIBreakState.h
Index: mozilla/mailnews/absync/src/nsAbSyncPostEngine.cpp
Index: mozilla/mailnews/base/src/nsCopyMessageStreamListener.cpp
Index: mozilla/mailnews/base/util/nsMsgFolder.cpp
Index: mozilla/mailnews/compose/src/nsURLFetcher.cpp
Index: mozilla/mailnews/local/src/nsLocalMailFolder.cpp
Index: mozilla/mailnews/local/src/nsParseMailbox.cpp
Index: mozilla/mailnews/mime/cthandlers/glue/nsMimeContentTypeHandler.cpp
Index: mozilla/mailnews/mime/src/nsMimeConverter.cpp
Index: mozilla/mailnews/mime/src/nsMimeObjectClassAccess.cpp
Index: mozilla/mailnews/mime/src/nsMsgHeaderParser.cpp
Index: mozilla/mailnews/mime/src/nsStreamConverter.cpp
Index: mozilla/mailnews/news/src/nsNewsFolder.cpp
Index: mozilla/widget/src/photon/nsWidget.cpp
Index: mozilla/xpcom/base/nsAgg.h
Index: mozilla/xpcom/components/nsXPComFactory.h

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 110632 [details]
treewide change

Timeless said on IRC that I have r=timeless with his changes.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: changes for closed partition

Comment 9

[Doug Turner (:dougt)]

dbaron, can you post a final patch for review?

Comment 10

[jag (Peter Annema)]

What was the nature of timeless' changes?

Comment 11

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Cleaning up some formatting issues, if I remember correctly.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

patch for remaining changes / new changes

Comment 13

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Remaining fix checked in to trunk, 2004-01-23 15:12 -0800.