Closed Bug 178643 Opened 22 years ago Closed 21 years ago

Remove uses of NS_INIT_ISUPPORTS from tree

Categories

(Core :: XPCOM, defect, P4)

defect

Tracking

()

RESOLVED FIXED
Future

People

(Reporter: dbaron, Assigned: dbaron)

Details

(Whiteboard: [treewide][patch])

Attachments

(4 files, 1 obsolete file)

Bug 174225 made NS_INIT_ISUPPORTS do nothing and deprecated it.  We should
remove the callers from the tree, although probably we should wait until the 1.0
branch is used less.
Priority: -- → P4
Whiteboard: [treewide]
Target Milestone: --- → Future
Status: NEW → ASSIGNED
This moves NS_INIT_ISUPPORTS to nsISupportsObsolete.h.	This might require
changes to the commercial tree before it is checked in since
nsISupportsObsolete.h is not included in many files.
Attached file treewide change (obsolete) —
This is a gzipped patch.  It was created using the files
replacer.sed:
-----
/^[	]*NS_INIT_ISUPPORTS[	]*([	]*);\?[ 	]*$/d
s/NS_INIT_ISUPPORTS[	]*([	]*);\?[ 	]*//
-----
replacer sh:
-----
(find mozilla -name "*".cpp; find mozilla -name "*".h) | while read FILENAME;
do  sed -f replacer.sed $FILENAME > $FILENAME.replacer.$$.tmp
  if diff $FILENAME $FILENAME.replacer.$$.tmp >& /dev/null; then
    rm $FILENAME.replacer.$$.tmp
  else
    echo $FILENAME
    mv $FILENAME.replacer.$$.tmp $FILENAME
  fi
done
-----
And then undoing the changes they made to the two files in the previous patch. 
Note that everything between [] in the sed script is a space followed by a tab.
Comment on attachment 110632 [details]
treewide change

Requesting r and sr.  I'm not expecting you to read every line... :-)
Attachment #110632 - Attachment is patch: false
Attachment #110632 - Attachment mime type: text/plain → application/x-gzip
Attachment #110632 - Flags: superreview?(jaggernaut)
Attachment #110632 - Flags: review?(dougt)
Attachment #110632 - Attachment is patch: true
Attachment #110632 - Attachment mime type: application/x-gzip → text/plain
Attachment #110632 - Attachment is patch: false
Attachment #110632 - Attachment mime type: text/plain → application/x-gzip
Comment on attachment 110630 [details] [diff] [review]
moving the macro to nsISupportsObsolete.h

sr=jag
Attachment #110630 - Flags: superreview+
Comment on attachment 110632 [details]
treewide change

sr=jag
Attachment #110632 - Flags: superreview?(jaggernaut) → superreview+
ok. this is fine, but i have a few minor things i wanted fixed so here's a
replacement patch, and the list of files i changed:

Index: mozilla/intl/ctl/src/nsULE.cpp
Index: mozilla/intl/lwbrk/public/nsIBreakState.h
Index: mozilla/mailnews/absync/src/nsAbSyncPostEngine.cpp
Index: mozilla/mailnews/base/src/nsCopyMessageStreamListener.cpp
Index: mozilla/mailnews/base/util/nsMsgFolder.cpp
Index: mozilla/mailnews/compose/src/nsURLFetcher.cpp
Index: mozilla/mailnews/local/src/nsLocalMailFolder.cpp
Index: mozilla/mailnews/local/src/nsParseMailbox.cpp
Index: mozilla/mailnews/mime/cthandlers/glue/nsMimeContentTypeHandler.cpp
Index: mozilla/mailnews/mime/src/nsMimeConverter.cpp
Index: mozilla/mailnews/mime/src/nsMimeObjectClassAccess.cpp
Index: mozilla/mailnews/mime/src/nsMsgHeaderParser.cpp
Index: mozilla/mailnews/mime/src/nsStreamConverter.cpp
Index: mozilla/mailnews/news/src/nsNewsFolder.cpp
Index: mozilla/widget/src/photon/nsWidget.cpp
Index: mozilla/xpcom/base/nsAgg.h
Index: mozilla/xpcom/components/nsXPComFactory.h
Attachment #110632 - Attachment is obsolete: true
Whiteboard: [treewide] → [treewide][patch]
Comment on attachment 110632 [details]
treewide change

Timeless said on IRC that I have r=timeless with his changes.
Attachment #110632 - Flags: review?(dougt)
dbaron, can you post a final patch for review?
What was the nature of timeless' changes?
Cleaning up some formatting issues, if I remember correctly.
Attached patch patchSplinter Review
patch for remaining changes / new changes
Attachment #139758 - Flags: superreview?(bryner)
Attachment #139758 - Flags: review?(bryner)
Attachment #139758 - Flags: superreview?(bryner)
Attachment #139758 - Flags: superreview+
Attachment #139758 - Flags: review?(bryner)
Attachment #139758 - Flags: review+
Remaining fix checked in to trunk, 2004-01-23 15:12 -0800.
Status: ASSIGNED → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: