1786494 - Rewrite MainThreadErrorContext with OffThreadErrorContext + a step to convert to runtime error

Status: RESOLVED FIXED

(Core :: JavaScript Engine, task, P1)

Description

[Tooru Fujisawa [:arai]]

Things to do:

• factor out the code around conversion fro OffThreadFrontendErrors to runtime error, from helper thread

https://searchfox.org/mozilla-central/rev/00e504083572d47f2199168f0f79c75c0ddaefb3/js/src/vm/HelperThreads.cpp#2334-2336

for (const UniquePtr<CompileError>& error : parseTask->ec_.errors()) {
  error->throwError(cx);
}

• possibly temporarily add a workaround to support MainThreadErrorContext-specific thing in OffThreadErrorContext as optional path. such as onAllocationOverflow and WASI recursion limit
• rewrite MainThreadErrorContext consumer to use OffThreadErrorContext and the conversion above
• remove MainThreadErrorContext

after them we can cleanup the code path around error reporting and OffThreadErrorContext in bug 1785762, and rename things with Frontend*

Comment 1

[Tooru Fujisawa [:arai]]

This requires all exceptions being set through ErrorContext in frontend,
including OOM during allocation.

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 1: Move the OffThreadFrontendErrors-to-runtime-error conversion to OffThreadErrorContext. r=bthrall!

Comment 3

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1786494 - Part 2: Add OffThreadErrorContext::setCurrentJSContext temporarily.

Depends on D156091

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1786494 - Part 3: Support allocation overflow in OffThreadErrorContext.

Depends on D156092

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1786494 - Part 4: Add ErrorContext::assertHadErrors.

Depends on D156093

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1786494 - Part 5: Add AutoReportFrontendContext and use it in CompilationAndEvaluation.cpp.

Depends on D156094

Comment 7

[Tooru Fujisawa [:arai]]

Attachment: WIP: Bug 1786494 - Part 6: Use AutoReportFrontendContext in js/src/builtin/.

Depends on D156095

Comment 8

[Tooru Fujisawa [:arai]]

remaining things to do:

• rewrite query on JSContext error status
• rewrite recover from error

Comment 9

[Tooru Fujisawa [:arai]]

Also:

• split error and warnings, and add different accessor

Comment 10

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 2: Support allocation overflow in OffThreadErrorContext. r=bthrall!

Depends on D156091

Comment 11

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 3: Cleanup ErrorContext::hadErrors. r=bthrall!

Depends on D157442

Comment 12

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 4: Add OffThreadErrorContext::maybeCx_. r=bthrall!

Depends on D157443

Comment 13

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 5: Add OffThreadFrontendErrors::warnings and Warning parameter to convertToRuntimeError. r=bthrall!

Depends on D157444

Comment 14

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 6: Always use ErrorContext::hadErrors in AutoAssertReportedException. r=bthrall!

Depends on D157445

Comment 15

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 7: Use ErrorContext in XDR error check. r=bthrall!

Depends on D157446

Comment 16

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 8: Use ErrorContext for checking errors in asm.js. r=bthrall!

Depends on D157447

Comment 17

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 9: Use ErrorContext for checking errors in BytecodeCompiler. r=bthrall!

Depends on D157448

Comment 18

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 10: Use ErrorContext::recoverFromOutOfMemory in EmitterScope. r=bthrall!

Depends on D157449

Comment 19

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 11: Add AutoReportFrontendContext and use it in CompilationAndEvaluation.cpp. r=bthrall!

The frontend error is converted into the runtime error in
AutoReportFrontendContext destructor, and it can GC.

If the function's return value is GC thing, AutoReportFrontendContext
destructor must be called before the return statement, and thus
AutoReportFrontendContext must be put into a block, and the return value
must be stored into JS::Rooted outside of the block.

Depends on D157450

Comment 20

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 12: Use AutoReportFrontendContext in simple cases. r=bthrall!

Depends on D157451

Comment 21

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 13: Use AutoReportFrontendContext with block for functions that returns GC things. r=bthrall!

Depends on D157452

Comment 22

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 15: Add AutoReportFrontendContext::{clearAutoReport,convertToRuntimeErrorAndClear} and use it in complex cases. r=bthrall!

Depends on D157453

Comment 23

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 16: Remove MainThreadErrorContext. r=bthrall!

Depends on D157454

Comment 24

[Tooru Fujisawa [:arai]]

Attachment: Bug 1786494 - Part 14: Add AutoPrintSelfHostingFrontendContext. r=bthrall!

Depends on D157453

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b43722447cb
Part 1: Move the OffThreadFrontendErrors-to-runtime-error conversion to OffThreadErrorContext. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/320050bb2c1d
Part 2: Support allocation overflow in OffThreadErrorContext. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/387a484747dd
Part 3: Cleanup ErrorContext::hadErrors. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/b29e3a509e61
Part 4: Add OffThreadErrorContext::maybeCx_. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/a9c6b783ae5f
Part 5: Add OffThreadFrontendErrors::warnings and Warning parameter to convertToRuntimeError. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/1d7e29232e58
Part 6: Always use ErrorContext::hadErrors in AutoAssertReportedException. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/deb867238cb2
Part 7: Use ErrorContext in XDR error check. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/c0fbf5e9476b
Part 8: Use ErrorContext for checking errors in asm.js. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/dd22e38e5474
Part 9: Use ErrorContext for checking errors in BytecodeCompiler. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/d8a24b7bd7d8
Part 10: Use ErrorContext::recoverFromOutOfMemory in EmitterScope. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/ca77d788facb
Part 11: Add AutoReportFrontendContext and use it in CompilationAndEvaluation.cpp. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/86a890c4b6fa
Part 12: Use AutoReportFrontendContext in simple cases. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/5210028e7137
Part 13: Use AutoReportFrontendContext with block for functions that returns GC things. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/328ec7d3e3ba
Part 14: Add AutoPrintSelfHostingFrontendContext. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/f31a45362842
Part 15: Add AutoReportFrontendContext::{clearAutoReport,convertToRuntimeErrorAndClear} and use it in complex cases. r=bthrall
https://hg.mozilla.org/integration/autoland/rev/0ac06d10a688
Part 16: Remove MainThreadErrorContext. r=bthrall

Comment 26

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/3b43722447cb
https://hg.mozilla.org/mozilla-central/rev/320050bb2c1d
https://hg.mozilla.org/mozilla-central/rev/387a484747dd
https://hg.mozilla.org/mozilla-central/rev/b29e3a509e61
https://hg.mozilla.org/mozilla-central/rev/a9c6b783ae5f
https://hg.mozilla.org/mozilla-central/rev/1d7e29232e58
https://hg.mozilla.org/mozilla-central/rev/deb867238cb2
https://hg.mozilla.org/mozilla-central/rev/c0fbf5e9476b
https://hg.mozilla.org/mozilla-central/rev/dd22e38e5474
https://hg.mozilla.org/mozilla-central/rev/d8a24b7bd7d8
https://hg.mozilla.org/mozilla-central/rev/ca77d788facb
https://hg.mozilla.org/mozilla-central/rev/86a890c4b6fa
https://hg.mozilla.org/mozilla-central/rev/5210028e7137
https://hg.mozilla.org/mozilla-central/rev/328ec7d3e3ba
https://hg.mozilla.org/mozilla-central/rev/f31a45362842
https://hg.mozilla.org/mozilla-central/rev/0ac06d10a688