1904747 - Error is reported by JS_Utf8BufferIsCompilableUnit

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Tooru Fujisawa [:arai]]

Bug 1786494 rewritten JS_Utf8BufferIsCompilableUnit to use AutoReportFrontendContext, but the error handling remains using cx,
which results in not clearing errors and reporting errors when the input is not compilable unit.

https://searchfox.org/mozilla-central/rev/67956a15835fc397334668525d528d471b19b273/js/src/vm/CompilationAndEvaluation.cpp#169-172,195-196,223

JS_PUBLIC_API bool JS_Utf8BufferIsCompilableUnit(JSContext* cx,
                                                 HandleObject obj,
                                                 const char* utf8,
                                                 size_t length) {
...
  AutoReportFrontendContext fc(cx,
                               AutoReportFrontendContext::Warning::Suppress);
...
    cx->clearPendingException();

Comment 1

[Tooru Fujisawa [:arai]]

JS_Utf8BufferIsCompilableUnit is used only by shell, so

• this doesn't affect browser
• but this affects SpiderMonkey embeddings

https://searchfox.org/mozilla-central/search?q=JS_Utf8BufferIsCompilableUnit&path=&case=false&regexp=false

Comment 2

[Tooru Fujisawa [:arai]]

Given this affects SpiderMonkey embeddings, I'd like to uplift this to 128, given it will be the next ESR.
is it okay?

Comment 3

[Donal Meehan [:dmeehan]]

Set 128 to affected but we don't have much time left in the cycle. This is the final week of beta if you have something safe to uplift.

Comment 4

[Tooru Fujisawa [:arai]]

Attachment: Bug 1904747 - Do not report error or warning in JS_Utf8BufferIsCompilableUnit. r?bthrall!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cc549315809f
Do not report error or warning in JS_Utf8BufferIsCompilableUnit. r=bthrall

Comment 6

[Tooru Fujisawa [:arai]]

Attachment: Bug 1904747 - Do not report error or warning in JS_Utf8BufferIsCompilableUnit. r?bthrall!

Original Revision: https://phabricator.services.mozilla.com/D214913

Comment 7

[Phabricator Automation]

beta Uplift Approval Request

• User impact if declined: This affects SpiderMonkey embeddings. the API behaves in unexpected way.
• Code covered by automated testing: yes
• Fix verified in Nightly: no
• Needs manual QE test: no
• Steps to reproduce for manual QE testing: none
• Risk associated with taking this patch: Very low
• Explanation of risk level: This API is not used by browser, but only by shells (xpcshell, spidermonkey shell)
• String changes made/needed: none
• Is Android affected?: no

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cc549315809f

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/34ebb58cf4af