1786504 - Fix onboarding link layout

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Dale Harvey (:daleharvey)]

+++ This bug was initially created as a clone of Bug #1779219 +++

As per spec @ https://www.figma.com/file/o7FiykrKIyDBgsjEQUYDOr/Quick-actions-in-the-Awesomebar?node-id=7%3A2288

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1786504 - Follow up to ensure onboarding button is correctly positioned. r=daisuke

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e16c8c2dbef9
Follow up to ensure onboarding button is correctly positioned. r=daisuke

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/e16c8c2dbef9

Comment 4

[Cristian Baica [:cbaica], Release Desktop QA]

Hey Dale,
Will the onboarding button be always positioned on the first row (currently that is the case in Firefox). Because figma specs show that whenever there is wrapping done, the button should be placed in the middle of the quickactions container. This is also the case when opening the quickaction section from the oneoff portion of the address bar drop-down.

Comment 5

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: help button position

Added a screenshot for a better view and comparison between current implementation and figma design.

Comment 6

[Dale Harvey (:daleharvey)]

We shouldnt actually have more than one row in any case, that is being tracked @ https://bugzilla.mozilla.org/show_bug.cgi?id=1783762

Comment 7

[Cristian Baica [:cbaica], Release Desktop QA]

Closing this as verified fixed since the wrap up is done differently in normal mode and the current implementation looks good for quickactions searchmode.