1786521 - Fix AppearanceValueAffectsFrames.

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1786521 - Fix AppearanceValueAffectsFrames. r=jfkthame,#layout

We had zero tests for this, and when I implemented the optimization to
avoid reframing in most cases I apparently swapped the arguments ;_;

Fix <input type=search> which suffered from the same issue, but we don't
ship by default.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:TYLin, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f9fe7434610
Fix AppearanceValueAffectsFrames. r=TYLin

Comment 6

[Cristina Cozmuta (:CrissCozmuta)]

https://hg.mozilla.org/mozilla-central/rev/3f9fe7434610

Comment 7

[James Graham [:jgraham]]

Given this was a regression which shipped and caused some compat issues, did we consider an uplift?

Comment 8

[Emilio Cobos Álvarez (:emilio)]

I think this landed during the soft-freeze, but I guess the patch is trivial so if we're doing a dot-release, might as well.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 9291148 [details]
Bug 1786521 - Fix AppearanceValueAffectsFrames. r=jfkthame,#layout

Beta/Release Uplift Approval Request

• User impact if declined: See dupes
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: none
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Relatively simple fixup to dynamic appearance changes.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1768155

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9291148 [details]
Bug 1786521 - Fix AppearanceValueAffectsFrames. r=jfkthame,#layout

Simple fix with a lot of new tests and a few dupe bugs filed now. Approved for 105.0.2 and 102.4esr.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/0271f9c8884a

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr102/rev/be8c504bf505

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Added to the 105.0.2 release notes:

Fixed a bug causing some dynamic appearance changes to appear when expected

Comment 15

[Kyungjoon Lee]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #14)

Added to the 105.0.2 release notes:

Fixed a bug causing some dynamic appearance changes to appear when expected

Hi, should that read “to not appear when expected”, please?

(As written, it made me wonder how it could be a bug if it caused things to appear when expected.)

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Good catch! I've updated the note and it should be live in the next 15-20min.