1786525 - [wayland] List all tabs popup doesn't work correctly with "Large text enabled"

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Emilio Cobos Álvarez (:emilio)]

Attachment: Screencast from 08-23-2022 04:29:06 PM.webm

See screencast. Might be related to bug 1717192.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1786525 - Don't update untransformed anchor rect when moved by move-to-rect. r=stransky

Otherwise, it changes the move-to-rect inputs, which can change the
output as well, making us move the anchor all the way to the right.

You could, I guess, consider this a mutter bug of sorts, because it
feels weird that you pass it an anchor that has been a move-to-rect
output and you get another rect as an output.

But also, it's kinda silly that we're doing that to begin with, so avoid
it by telling the popup frame whether it's been positioned / moved by
move-to-rect (and keeping the anchor in that case).

The reason this works on my setup without "Large text" is just dumb luck
(the front-end computes a max-height for the panel that is small enough
to fit on the screen).

Comment 2

[Martin Stránský [:stransky] (ni? me)]

Do you mind to file that at https://gitlab.gnome.org/GNOME/mutter/-/issues ?

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Will do.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bb1d2a4a5570
Don't update untransformed anchor rect when moved by move-to-rect. r=stransky

Comment 5

[Sandor Molnar[:smolnar]]

Backed out changeset bb1d2a4a5570 (bug 1786525) for causing build bustages in xpfe/appshell/AppWindow.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/cb0a9cf25fa0145da6485806aec2bf551096d3d0

Push with failures

Failure log

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/664b5e3d5ebc
Don't update untransformed anchor rect when moved by move-to-rect. r=stransky

Comment 7

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/664b5e3d5ebc