1786804 - Put the @font-face src tech() function behind a pref

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Jonathan Kew [:jfkthame]]

In bug 1715546, we added the tech() function to the @font-face src descriptor. However, there are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this.

• In https://github.com/w3c/IFT/pull/113, the WebFonts WG proposes several new incremental-* keywords (and maybe implies dropping the currently-defined incremental?)

• In https://github.com/w3c/csswg-drafts/issues/7633, I just proposed renaming the feature-* keywords to features-* (plural) for better readability; I'd like to see a decision on that before we ship this to release.

So I suggest we should put the parsing of tech(...) behind a pref, and enable it only on Nightly for now. (We'll want to uplift this to beta-105, as bug 1715546 is already there.)

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1786804 - Put the @font-face src tech() function behind a pref, enabled only on Nightly for now. r=emilio

Comment 2

[Jonathan Kew [:jfkthame]]

Comment on attachment 9291328 [details]
Bug 1786804 - Put the @font-face src tech() function behind a pref, enabled only on Nightly for now. r=emilio

Beta/Release Uplift Approval Request

• User impact if declined: The new tech() function for CSS @font-face will be exposed prematurely (see comment 0).
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Trivial patch, just adds a pref to control parsing the new function, and defaults to nightly-only.
• String changes made/needed: none
• Is Android affected?: Yes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fad9d7923691
Put the @font-face src tech() function behind a pref, enabled only on Nightly for now. r=emilio

Comment 4

[Jonathan Kew [:jfkthame]]

Attachment: Bug 1786804 followup - ensure the pref is set for reftest that requires it. r=emilio

We need to include this, otherwise the test will start failing on beta.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7aa31a6b0ed8
followup - ensure the pref is set for reftest that requires it. r=emilio

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/fad9d7923691

Comment 7

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/7aa31a6b0ed8

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 9291328 [details]
Bug 1786804 - Put the @font-face src tech() function behind a pref, enabled only on Nightly for now. r=emilio

Approved for 105.0b3.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/8b0b2c2d4a15