Closed Bug 1786804 Opened 3 months ago Closed 3 months ago

Put the @font-face src tech() function behind a pref

Categories

(Core :: CSS Parsing and Computation, defect)

defect

Tracking

()

RESOLVED FIXED
106 Branch
Tracking Status
firefox105 + fixed
firefox106 --- fixed

People

(Reporter: jfkthame, Assigned: jfkthame)

Details

Attachments

(2 files)

In bug 1715546, we added the tech() function to the @font-face src descriptor. However, there are a couple of current issues/discussions that may lead to a change in the set of supported keywords, so we may want to hold back a little on actually shipping this.

So I suggest we should put the parsing of tech(...) behind a pref, and enable it only on Nightly for now. (We'll want to uplift this to beta-105, as bug 1715546 is already there.)

Comment on attachment 9291328 [details]
Bug 1786804 - Put the @font-face src tech() function behind a pref, enabled only on Nightly for now. r=emilio

Beta/Release Uplift Approval Request

  • User impact if declined: The new tech() function for CSS @font-face will be exposed prematurely (see comment 0).
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: No
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Trivial patch, just adds a pref to control parsing the new function, and defaults to nightly-only.
  • String changes made/needed: none
  • Is Android affected?: Yes
Attachment #9291328 - Flags: approval-mozilla-beta?
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/fad9d7923691
Put the @font-face src tech() function behind a pref, enabled only on Nightly for now. r=emilio

We need to include this, otherwise the test will start failing on beta.

Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7aa31a6b0ed8
followup - ensure the pref is set for reftest that requires it. r=emilio
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch

Comment on attachment 9291328 [details]
Bug 1786804 - Put the @font-face src tech() function behind a pref, enabled only on Nightly for now. r=emilio

Approved for 105.0b3.

Attachment #9291328 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.