1787128 - Stop composing error state fluent message identifiers in Firefox View

Status: RESOLVED FIXED

(Firefox :: Firefox View, task, P2)

Description

[:Gijs (he/him)]

See discussion on https://phabricator.services.mozilla.com/D154675 .

Rather than having a specialcase for 1 string at https://searchfox.org/mozilla-central/rev/30ac44262374be08ccd4262ee36f0716152868d3/browser/components/firefoxview/tab-pickup-container.mjs#167-170 , let's use a mapping from error state to string identifiers. This has the benefits that it's easy to update just 1 string identifier in future, and that it's easy to figure out where strings are used by just searching for string identifiers.

Comment 1

[Mike Conley (:mconley) (:⚙️) (PTO Dec 22 - Jan 2)]

Attachment: Bug 1787128 - Explicitly define TabPickupContainer's error message IDs rather than composing them. r?sclements!

While this introduces some redundancy, the advantage to spelling out the error message IDs like
this explicitly is that if the string ever needs to be updated (which requires a message ID
change), then we have a single place to remap the error code strings to the message IDs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c50a8b342d63
Explicitly define TabPickupContainer's error message IDs rather than composing them. r=sclements

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c50a8b342d63