1787246 - Website login popup prompt not following content color scheme

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Blake]

Attachment: Login Prompt.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

When a website or web server popups a login prompt, it should follow the system theme. Currently it is no long dark.

Comment 1

[Blake]

First bad build from Mozregression:

app_name: firefox
build_date: 2022-08-24 15:18:37.970000
build_file: C:\Users%username%.mozilla\mozregression\persist\e7557b1a23fe-shippable--autoland--target.zip
build_type: integration
build_url: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/X6M2rJ5xRq6DN5lZin7ceQ/runs/0/artifacts/public%2Fbuild%2Ftarget.zip
changeset: e7557b1a23feff6341b40daca25f3fd1c4165ebb
pushlog_url: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=024f1d0a67a320d9deb224e4d7ce5d0049432067&tochange=e7557b1a23feff6341b40daca25f3fd1c4165ebb
repo_name: autoland
repo_url: https://hg.mozilla.org/integration/autoland
task_id: X6M2rJ5xRq6DN5lZin7ceQ

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Theme' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Sam Foster [:sfoster] (he/him)]

:emilio, from the pushlog this looks to have been a regression from Bug 1786597

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Can't repro with the patch from bug 1782596, please update and reopen if you can?

Comment 5

[Fanolian]

Build ID: 20220825222149
For me on Windows 10,

OS color = Dark
Nightly theme = Dark (not System theme)
Nightly Settings > General > Website appearance = Dark (not Nightly theme)
====> Modal windows, e.g. alert(), is Light. It was Dark before 2022-08-25 build.

This should be regressed by bug 1786597 rather than bug 1782596.

Last good Nightly: 2022-08-24
First bad Nightly: 2022-08-25
pushlog: https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=024f1d0a67a320d9deb224e4d7ce5d0049432067&tochange=58735c4baea39ac2be1ebf546e9180795009720e

Bisecting autoland builds:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=d8e8c71595491e958be68d7411462ebc151946b9&tochange=e7557b1a23feff6341b40daca25f3fd1c4165ebb

Comment 6

[Fanolian]

Attachment: testcase for bug 1787246.html

This is my testcase for comment 5.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Okay, I can't repro on Linux but will try to poke on Windows, thanks!

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1786597

Comment 9

[Dão Gottwald [:dao]]

(In reply to Blake from comment #0)

Created attachment 9291571 [details]
Login Prompt.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

When a website or web server popups a login prompt, it should follow the system theme. Currently it is no long dark.

What's your browser theme? It follows that I think, same as the page context menu. This is technically consistent, although also somewhat arbitrary. You could make an argument (and I have done so in the past) that it makes sense for these things to adopt the content color scheme, and if we don't do that we only encourage authors to replace these browser-provided things with their own implementation that would integrate better with their page.

Comment 10

[Blake]

(In reply to Dão Gottwald [::dao] from comment #9)

(In reply to Blake from comment #0)

Created attachment 9291571 [details]
Login Prompt.PNG

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:106.0) Gecko/20100101 Firefox/106.0

Steps to reproduce:

When a website or web server popups a login prompt, it should follow the system theme. Currently it is no long dark.

What's your browser theme? It follows that I think, same as the page context menu. This is technically consistent, although also somewhat arbitrary. You could make an argument (and I have done so in the past) that it makes sense for these things to adopt the content color scheme, and if we don't do that we only encourage authors to replace these browser-provided things with their own implementation that would integrate better with their page.

I just tested it with all four themes and they all show a bright white box to login to. I don't have any accessibility or high contract settings on either Firefox or Windows

Comment 11

[Blake]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #4)

Can't repro with the patch from bug 1782596, please update and reopen if you can?

*** This bug has been marked as a duplicate of bug 1782596 ***

I'm still seeing the issue on this mornings nightly build. Do I need to manually grab that patch or should I retest in autoland?

Comment 12

[Emilio Cobos Álvarez (:emilio)]

No, it's probably just windows-specific.

Comment 13

[Dão Gottwald [:dao]]

(In reply to Emilio Cobos Álvarez (:emilio) from comment #12)

No, it's probably just windows-specific.

I can reproduce this on Linux, unless I'm misunderstanding the problem and what the desired behavior would be.

I have a light Firefox theme with Website appearance set to Dark (the reporter presumably gets it from the system instead which would have the same effect). I get a light login prompt and I think the ask here is to make it match content instead?

Comment 14

[Emilio Cobos Álvarez (:emilio)]

No, the issue is: You have dark Firefox theme with dark content appearance, and regardless of whether the page uses light or dark color-schemes the dialog is light. That is because on Windows tabpanels are light, because of this rule. That isn't overridden by the tabbrowser tabpanels (like it is for the tabbrowser tabs here).

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1787246 - Fix color-scheme of tabbrowser tabpanels. r=dao

I chose to keep the unset nearby to where the appearance: none was set,
lmk if you disagree and I can move it to tabs.css or what not.

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/34df7c20a5f2
Fix color-scheme of tabbrowser tabpanels. r=dao

Comment 18

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/34df7c20a5f2

Comment 19

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on a 2022-08-25 Nightly build on Windows 10 using the testcase from Comment 6. Verified as fixed on Firefox 106.0b4(build ID: 20220925185751) and Nightly 107.0a1(build ID: 20220925213821) on Windows 10. macOS 12 and Ubuntu 22.04 seem to be unaffected.