1787448 - Spellcheck - if suggestions too many - bottom edge exceeds screen height and loses 'Close' button

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Anje]

Attachment: spellcheck.jpg

Reporting issue.
If spellcheck offers too many potential spelling options then the window keeps extending below edge of screen and the lower options are not visible and also the 'Close' button disappears.

User can only close the spellcheck window using top right 'x'.

Quote from user in Support Forum:

i type emails in 3 languages 4 in the future, so i have 3 dictionaries installed check before i send. if im ok its fine. if it finds minor errors i get 4-5 recommendations. if i am writing something weird like technical notes the suggested list of corrections gets so long it forces the dialogue box off screen. the top is ok, but the cancel, send etc buttons on the bottom are out of reach and i cannot resize the window to see them.
See:
https://support.mozilla.org/en-US/questions/1387202

Expectation:
Vertical scrollbar to appear if Spellcheck window height exceeds height of Write window.

Comment 1

[Magnus Melin [:mkmelin]]

https://searchfox.org/comm-central/rev/fc10933f51ae7eb704796df2d3e1c7af0fd998be/mail/components/compose/content/dialogs/EdSpellCheck.xhtml#72 needs max height I suppose

Comment 2

[Richard Marti (:Paenglab)]

Attachment: Bug 1787448 - Set a max-height on the spellcheck suggestion list. r=aleca

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/805177a45f28
Set a max-height on the spellcheck suggestion list. r=aleca

Comment 4

[Richard Marti (:Paenglab)]

Comment on attachment 9292862 [details]
Bug 1787448 - Set a max-height on the spellcheck suggestion list. r=aleca

[Approval Request Comment]
User impact if declined: spellcheck dialog can grow too much with a lot of suggestions
Testing completed (on c-c, etc.): on c-c
Risk to taking this patch (and alternatives if risky): low

Comment 5

[Wayne Mery (:wsmwk)]

Comment on attachment 9292862 [details]
Bug 1787448 - Set a max-height on the spellcheck suggestion list. r=aleca

[Triage Comment]
Approved for beta

Comment 6

[Daniel Darnell [:dandarnell]]

Thunderbird 105.0b3:
https://hg.mozilla.org/releases/comm-beta/rev/41deb2f9cfed

Comment 7

[Wayne Mery (:wsmwk)]

Comment on attachment 9292862 [details]
Bug 1787448 - Set a max-height on the spellcheck suggestion list. r=aleca

[Triage Comment]
Approved for esr102

Comment 8

[Rob Lemley [:rjl]]

Thunderbird 102.3.0:
https://hg.mozilla.org/releases/comm-esr102/rev/5dec57ca4e7f