1787462 - click on a history item, it automatically scrolls for a few lines, making a double click launch the wrong bookmark.

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[robinh3123]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

Steps to reproduce:

1. History -> manage history -> This month (so that the history list is a long one)
2. Crazily fast scroll the mouse wheel down, for about 10+~20+ pages The menu will be scrolling up fast.
3. Double click on an item to launch it.

Actual results:

A different item is launched.

Expected results:

The selected (i.e. double-clicked) item should be launched.

Comment 1

[robinh3123]

Note: A single click can also reveal the problem:
If you replace the last double click with a single click, you can see that, your item is correctly selected. However, the list will scroll a bit more (2 or 3 lines). That's why your second click of the double click chose the wrong one.

If, you let it sit for a bit more time, say 2 seconds before the double click, it will behave correctly.

Some guesses for the cause:

• Possibly the scrolling events from Linux X-Windows are queued, and received after the double click due to asynchronous event dispatch?
• Possible solution is in the application side, to filter out those scroll events which was right after (say, with in 2 seconds) the double click events.

Comment 2

[robinh3123]

Or possibly, if the event dispatch are asynchronous, but they might have a timestamp, Please check the timestamps and discard out-of-order events.

Comment 3

[robinh3123]

Sorry now I found the root cause.

Here's the true reproduction steps:

1. History-> manage history -> This mouth
   At this stage, make sure your bottom part of the history list has shown only the Name field.
   If you have previously click on any item, it will show Name, URL, and Tags at the bottom.
   In that case, click on Side-panel "History", then "This month" again.
   Now the bottom of the list only shows "Name" field.
2. Double click on one of the last few item of the page.

Expect behavior:
The correct item is launched.

Actual behavior:
Because Firefox wants to show more fields, such as URL and Tags. When Firefox did that, it needs some space. So the last few lines are affected. Not just the history, the bookmarks are subject to the same problem: They could show more fields like URL, Tags, and Keyword (3 more fields).

When an item at the top portion, the behavior is OK, since Firefox just make the bottom information potion bigger, which covers some lower part items. Since the target is high there, it won't be affected. If an item in the low part is selected, the behavior is tried to make the information part bigger, while scrolling the target item up so that it won't be covered by the enlarged information area. This cause an item list shift, and the wrong double click target were chosen.

Comment 4

[Alice0775 White]

I can reproduce the issue(wrong history entry will open when double click) in Nightly106.0a1 Windows10.

STR:

1. Open Ctrl+Shift+H
2. Change history time range (which contains many entries) on the left side pane.
   --- The right side pane is overflowing and the detail pane shows only one field(name of the time range).
3. Scroll the right side pane
4. Double click on a history entry

Actual results:
A wrong history entry will open.

• After first click, the right side pane will scroll.
• Subsequent click will trigger on the wrong entry because the list has been scrolled.

Expected results:
The double-clicked entry should open.
The right side pane should not scroll at least first click.

Comment 5

[robinh3123]

Attachment: Firefox bug: extra scrolls causing double click to pick the wrong target.

Comment 6

[Alice0775 White]

Regression window:

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2e154dcda079ad6ca50bc5d18cbd0991386c5989&tochange=2ca189b8925dba3f28a1cefdc3e6f143ffbee290

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

:jteow, since you are the author of the regressor, bug 1471546, could you take a look?
For more information, please visit auto_nag documentation.

Comment 8

[James Teow [:jteow]]

This should be "solved" in FF 106 due to Bug 1786518 because selecting an item near the bottom of the menu will no longer scroll the window after the details pane is expanded. So I'm going to mark this as "fixed" and denote which version of Firefox we should expect to see the change.

However, we'll go back to the previous problem of clicking an item near the end of the scroll-able list will hide the selected item because the detailsPane will expand and resize the window containing the list of history items / bookmarks (Bug 1471546).

We've added Bug 1786322 which will be a better long-term solution for these type of issues.

Comment 9

[Ardelean Oana, Desktop QA [:oardelean]]

I managed to reproduce this issue on a 2022-08-25 Nightly build on Ubuntu 22.04 using the STR from the Description. Verified as fixed on Firefox 106.0b4(build ID: 20220925185751) and Nightly 107.0a1(build ID: 20220925213821) on Ubuntu 22.04, Windows 10, macOS 12.