1787628 - Unable to compile js shell on Linux

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P3)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

/snip
Traceback (most recent call last):
  File "/home/skygentoo/trees/mozilla-central/js/src/../../configure.py", line 33, in <module>
    from mozbuild.configure import (
  File "/home/skygentoo/trees/mozilla-central/python/mozbuild/mozbuild/configure/__init__.py", line 28, in <module>
    from mozbuild.configure.util import ConfigureOutputHandler, getpreferredencoding, LineIO
  File "/home/skygentoo/trees/mozilla-central/python/mozbuild/mozbuild/configure/util.py", line 17, in <module>
    from looseversion import LooseVersion
ModuleNotFoundError: No module named 'looseversion'

I'm now unable to compile Linux js shell using:

AR=ar sh ./configure --enable-debug --with-ccache --enable-gczeal --enable-debug-symbols --disable-bootstrap --disable-tests

Tested on m-c rev a460318b0814.

The first bad revision is:
changeset:   https://hg.mozilla.org/mozilla-central/rev/a460318b0814
user:        ahochheiden
date:        Fri Aug 26 23:05:25 2022 +0000
summary:     Bug 1777414 - Replace all uses of `distutils.version.LooseVersion` with `looseversion.LooseVersion` r=firefox-build-system-reviewers,glandium

I tried re-running ./mach bootstrap --app=js but it didn't seem to help.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1777414

Comment 2

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

(In reply to Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now) from comment #0)

I'm now unable to compile Linux js shell using:

AR=ar sh ./configure --enable-debug --with-ccache --enable-gczeal --enable-debug-symbols --disable-bootstrap --disable-tests

Are there any docs for this command (or additional information you could provide)? ./configure doesn't seem to map to anything on my Ubuntu machine and I don't see anything obvious related to this on Building and testing SpiderMonkey.

./mach configure and ./mach build both seem to work fine after bootstrapping to --app=js.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

I create an objdir then point to configure in js/src/. I have done this for decades in my time in the Mozilla community.

The guide that you point to seems to indicate that this method is now deprecated though. "This replaces old guides that advised running the “configure” script directly."

Steve, is this method no longer supported for compiling js builds?

Comment 4

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Okay, I think all you'll need to do to get around this then is to create a mozconfig with this in it:

ac_add_options --enable-application=js
ac_add_options --enable-debug
ac_add_options --with-ccache
ac_add_options --enable-gczeal
ac_add_options --enable-debug-symbols
ac_add_options --disable-bootstrap
ac_add_options --disable-tests

Then run ./mach configure and it should do what you need.

I think the root of the problem you're encountering is that you're not in the mach virtualenv when you invoke configure that way, and all the 'imports' for the mach site aren't done since you're just in the system Python environment. I'm sure you could find a way to make it work, but I think using ./mach configure together with mozconfig will probably be easier in the long run.

Comment 5

[Mike Hommey [:glandium]]

configure (without mach) is still supposed to work.

Comment 6

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1787628 - Add `looseversion` import to `configure.py` r?#build

Comment 7

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Thanks for pointing me in the right direction @Glandium.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c5dc125ea32b
Add `looseversion` import to `configure.py` r=firefox-build-system-reviewers,glandium

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c5dc125ea32b

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:ahochheiden, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox105 to wontfix.

For more information, please visit auto_nag documentation.