1777414 - Refactor `distutils.version.LooseVersion` and distutils.version.StrictVersion` to `packaging.version.Version`

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, task, P3)

Description

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

As outlined in Bug 1743785, this is a "sub-bug" for the refactoring/removal of distutils, specifically for LooseVersion and StrictVersion.

Comment 1

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1777414 - Refactored most uses of `LooseVersion` and `StrictVersion` from `distutils` to `packaging.version.Version` r?#build

All "versions" should now be Version objects and they can no longer be
compared against hard-coded strings. As such, all hard-coded are also
constructed into Version objects so that they can be compared..

I also removed the Version class that inherited from LooseVersion in
configure/util.py. The resulting difference is that 'patch' is no
longer an available attribute, it is now called 'micro'. I did this for
the sake of consistency (Everything following the same naming convention
found in packaging.version.Version).

In packaging.version there is also a LegacyVersion which is less
strict, similar to LooseVersion. I chose not to use this at all since
it is already deprecated and is slated for removal. Comparing a
LegacyVersion against a Version always results in the
LegacyVersion object being less, which is not intuitive and can
cause unexpected behavior.

Comment 2

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

I was not able to come up with a way to get esr versions to work with packaging.version.Version. As per PEP440 esr is not a valid version component. Maybe there's an obvious workaround I'm not seeing, but for now I've left mozrelease/version.py and release/update-verify-config-creator.py unchanged.

Comment 3

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1777414 - Vendor standalone 'looseversion' at version 1.0.1 r?#build

This will be used to replace the LooseVersion within distutils.
StrictVersion from distutils will need something else, as swapping
usages of StrictVersion with LooseVersion does not result in the
desired behavior.

Comment 4

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1777414 - Remove Python2 specific code from our `Version` subclass r?#build

Depends on D151062

Comment 5

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1777414 - Replace all uses of `distutils.version.LooseVersion` with `looseversion.LooseVersion` r?#build

Depends on D151063

Comment 6

[Alex Hochheiden [:ahochheiden] (needinfo? me)]

Attachment: Bug 1777414 - Replace all uses of `distutils.version.StrictVersion` with `packaging.version.Version` r?#build

Some minor tweaking to the logic in MozillaVersionCompareMixin was
necessary to get comparisons between LooseVersion and Version with
esr suffixes working as desired.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e410f86b09a5
Vendor standalone 'looseversion' at version 1.0.1 r=firefox-build-system-reviewers,glandium

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/e410f86b09a5

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d8c248b75a5b
Remove Python2 specific code from our `Version` subclass r=firefox-build-system-reviewers,glandium

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a460318b0814
Replace all uses of `distutils.version.LooseVersion` with `looseversion.LooseVersion` r=firefox-build-system-reviewers,glandium

Comment 11

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d8c248b75a5b
https://hg.mozilla.org/mozilla-central/rev/a460318b0814

Comment 12

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/d8c248b75a5b
https://hg.mozilla.org/mozilla-central/rev/a460318b0814