Increase the blob tile size to 512x512
Categories
(Core :: Graphics: WebRender, enhancement, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox106 | --- | fixed |
People
(Reporter: nical, Assigned: nical)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
It improves blob rasterization and upload time in almost all test cases I've come across, especially the challenging ones. The only downside is that we lose invalidation granularity
|
Assignee | |
Comment 1•2 years ago
|
||
It improves rasterization and upload times by a lot in almost all of the test cases I can find. The only drawback is that our invalidation granulatiry is the tile so invalidation gets coarser as we increase the tile size.
512 is a bit special because it is the limit above which a different texture upload path is taken, so there will be more risk of performance side effects if/when we decide to make tiles even larger.
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f9e4f4b4131 Increase the blob tile size to 512. r=jrmuizel
|
||
Comment 3•2 years ago
|
||
Backed out changeset 2f9e4f4b4131 (bug 1787706) for causing reftest/wpt failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/d634c168519a7ba6dd524652cc87a93446b83438
|
|
Assignee | |
Updated•2 years ago
|
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7223a50e6cbf Increase the blob tile size to 512. r=jrmuizel
|
||
Comment 5•2 years ago
•
|
||
Backed out changeset 7223a50e6cbf (Bug 1787706) for causing reftest failures on 1524353.html and marker-path-021.svg.
Backout link
Push with failures <--> R3 and Wr6
Failure Log R3
Failure Log Wr6
Also R2 Failure Log
Also R25 Failure Log
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c8b33bd2b4bf Increase the blob tile size to 512. r=jrmuizel
|
||
Comment 7•2 years ago
|
||
Backed out for causing reftest failures at webkit-text-stroke-property-004.html.
Backout link: https://hg.mozilla.org/integration/autoland/rev/fbebfb6cd2358f7e426e19e90d773d7ca8bd8746
Failure log: https://treeherder.mozilla.org/logviewer?job_id=388935309&repo=autoland&lineNumber=18321
|
|
Assignee | |
Updated•2 years ago
|
Pushed by nsilva@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/105858693e9a Increase the blob tile size to 512. r=jrmuizel
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
Description
•