1788044 - The secondary CTA button from the "Downloading langpack" screen of the "about:welcome" page is wrongly labeled "Skip" instead of "Skip this step"

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

Attachment: rec of the issue.gif

[Affected versions]:

• Firefox Nightly 106.0a1 - Build ID: 20220830092750

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.5
• Linux Mint 20.2 x64

[Prerequisites]:

• Have the following prefs in the "about:config" page:
  • extensions.getAddons.langpacks.url set to https://mock-amo-language-tools.glitch.me/?app=firefox&type=language&appversion=%VERSION%
  • intl.multilingual.aboutWelcome.languageMismatchEnabled set to true
  • intl.multilingual.aboutWelcome.systemLocaleOverride set to es-CO
  • browser.aboutwelcome.templateMR set to true
  • devtools.chrome.enabled set to true
• Have the "Browser Console" opened.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Focus the "Browser Console" and enter the string from here.
3. Navigate to the "about:welcome" page and click the "Skip this step" button from the first screen.
4. Observe the secondary CTA button label from the "Downloading langpack" screen.

[Expected result]:

• The button is labeled "Skip this step".

[Actual result]:

• The button is labeled "Skip".

[Additional Notes]:

• O the rest of the Onboarding screens the secondary CTA button is labeled "Skip this step".
• Attached a screen recording of the issue.

Comment 1

[Ed Lee :Mardak]

Bug 1778792 probably wanted to also update skip to use mr2022-onboarding-secondary-skip-button-label

Comment 2

[Negin Sauermann]

Attachment: Bug 1788044 - The secondary CTA button from the "Downloading langpack" screen of the "about:welcome" page is wrongly labeled "Skip" instead of "Skip this step"

{F4112412}

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d55d2b15801e
The secondary CTA button from the "Downloading langpack" screen of the "about:welcome" page is wrongly labeled "Skip" instead of "Skip this step" r=emcminn

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/d55d2b15801e

Comment 5

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (106.0a1 Build ID - 20220901095452) installed on Windows 10 x64, macOS 11.6.5, and Linux Mint 20.2 x64. Now, I can confirm that the secondary CTA button is labeled "Skip this step".