1778792 - Update language mismatch screen in MR onboarding

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P1)

Description

[Ania]

User Story
As a new user whose system and downloading browser languages do not match, I would like to be offered a choice to pick the language I’m most comfortable with in Firefox during the onboarding.

Figma File

Acceptance Criteria

1. New users can select the language option they’re most comfortable with between their system and downloading browser language, so they experience all subsequent onboarding screens and Firefox at large in their chosen language.

2. The choice is presented to new users experiencing the mismatch only once. If the language choice is unavailable because of the network being too slow and language options not loading, we will not display it in the future.

3. If the network request to get and download langpacks didn’t return a response or returned an error when a user transitions from the previous Onboarding screen, the language mismatch screen is not presented to a user at all.

4. If user has made a choice of language in this screen, we store a variable or a user property that signifies their preferred language. This will allow us to avoid showing this screen twice to existing users who have already made a choice in the past.

5. The prompt to switch to the system language is displayed in the system language, as is the text (Firefox speaks your language) on the left hand side.

Comment 1

[Ania]

Attachment: lang-mismatch-template.png

Comment 2

[Ania]

Attachment: lang-mismatch-example.png

Comment 3

[Ania]

Attachment: lang-mismatch-responsive.png

Comment 4

[hanna A]

Attachment: Bug 1778792 - Update language mismatch screen in MR onboarding r=flod,Mardak

Comment 5

[Ed Lee :Mardak]

Bug 1479013 shows both the incoming locale and current locale when switching languages from about:preferences with a custom bundle instead of relying on the usual document.l10n or fluent-dom behavior. It makes explicit calls to formatValue that we haven't used for about:welcome, so it would be a bit more work to start supporting that.

https://searchfox.org/mozilla-central/rev/4f2984be127d2e7c788cf1848d63dca63022beec/browser/components/preferences/main.js#1062-1072

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/144868fa5739
Update language mismatch screen in MR onboarding r=fluent-reviewers,flod,Mardak

Comment 7

[Noemi Erli[:noemi_erli]]

Backed out changeset 144868fa5739 (Bug 1778792) for causing newtab failures CLOSED TREE

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=C28cMHjWQvSe8IN3kvxQWQ.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=144868fa57396c32ff6a966b61ffa7bc27d2fee2

Log: https://treeherder.mozilla.org/logviewer?job_id=387795801&repo=autoland&lineNumber=108

Backout: https://hg.mozilla.org/integration/autoland/rev/bb97b219e0c84adcee053d11874ac557f0ad8f1c

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/483dbc4691da
Update language mismatch screen in MR onboarding r=fluent-reviewers,flod,Mardak

Comment 9

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/483dbc4691da

Comment 10

[Simona Rosu [:srosu], Ecosystem QA]

I‘ve verified this enhancement using the latest Firefox Nightly 106.0a1 (Build ID: 20220823214727) and Firefox Beta 105.0b2 (Build ID: 20220823185840) on Windows 10 x64, macOS 12.5.1, and Linux Mint 20.2 x64.

• The "Choose Language" screen is only displayed for new users if the OS and browser languages do not match.
• The screen is correctly displayed after the intro screen of the “about:welcome” page.
• The title from the right part of the screen, the body text, and the “Continue in <Browser Language>” button are displayed in browser language.
• The body text correctly mentions the system and browser languages that are used.
• The OS language is applied to the browser if the “Switch to <OS Language>” button is accessed.
• The OS language is not applied to the browser if the “Continue in <Browser Language>” button is accessed.
• Also, the "Choose Language" screen is not displayed if there is no language mismatch between the OS and browser.

During verifying this enhancement, I’ve noticed that the title from the left part of the screen and the first button are not displayed in the OS language in some circumstances. I filled a new issue (Bug 1786784) for this behavior.