1788076 - The "Show detailed information" option from the "about:preferences#privacy" page is wrongly selected if the "Use Firefox recommendations" button from the "Privacy Segmentation" Onboarding modal was clicked

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

Attachment: rec of the issue.gif

[Notes]:

• The "Use Firefox recommendations" option from the "about:preferences#privacy" page is selected by default.
• If the "Use Firefox recommendations" option from the "about:preferences#privacy" page is selected the "browser.privacySegmentation.enabled" pref is set to "false".
• If the "Show detailed information" option from the "about:preferences#privacy" page is selected the "browser.privacySegmentation.enabled" pref is set to "true".
• If the "Use Firefox recommendations" button from the "Privacy segmentation" Onboarding modal is clicked the "browser.privacySegmentation.enabled" pref is set to "true".
• If the "Show detailed information" button from the "Privacy segmentation" Onboarding modal is clicked the "browser.privacySegmentation.enabled" pref is set to "false".

[Affected versions]:

• Firefox Nightly 106.0a1 - Build ID: 20220830092750

[Affected Platforms]:

• Windows 10 x64
• macOS 11.6.5
• Linux Mint 20.2 x64

[Prerequisites]:

• Have the following prefs in the "about:config" page:
• browser.aboutwelcome.templateMR set to true
• devtools.chrome.enabled set to true
• Have the "Browser Console" opened.

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Focus the "Browser Console" and run the "Cc["@mozilla.org/browser/browserglue;1"].getService().wrappedJSObject._showUpgradeDialog();" string.
3. Navigate to the "Privacy segmentation" modal and click the "Use Firefox recommendations" button.
4. Navigate to the "about:preferences#privacy" page and observe the options from the "New features that enhance you browsing" section.

[Expected result]:

• The "Use Firefox recommendations" option is selected.

[Actual result]:

• The "Show detailed information" option is selected instead.

[Additional Notes]:

• If the "Show detailed information" button from the "Privacy segmentation" Onboarding modal is clicked the "Use Firefox recommendations" option from the "about:preferences#privacy" page is selected instead.
• Attached a screen recording of the issue.

Comment 1

[Punam Dahiya [:pdahiya]]

Privacy segmentation screen sets respective pref as noted here https://bugzilla.mozilla.org/show_bug.cgi?id=1779514#c6 . NI @Ania to help look into the desired behavior for about:preferences and if the setting shows as expected

Comment 2

[Ed Lee :Mardak]

Reviewing this again, about:preferences seems more logical:
Firefox recommendations - > set browser.privacySegmentation.enabled pref to false.
Detailed information -> set browser.privacySegmentation.enabled pref to true.

Comment 3

[Ed Lee :Mardak]

Looks like bug 1788697 will fix this by changing the pref name as well as about:preferences behavior so that true is first for "Use Firefox recommendations"

Comment 4

[Ed Lee :Mardak]

Fixed with bug 1788697
https://hg.mozilla.org/mozilla-central/rev/8ba5432d1be8

Comment 5

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

This issue was verified as part of the verification process performed on bug 1788697. Considering this I am marking this issue as verified.