1788088 - SERP Telemetry is recorded as "unknown" rather than "urlbar" when using the address bar with browser.urlbar.openintab set to true (or when alt-enter)

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[Mark Banner (:standard8)]

STR

1. Start Firefox.
2. Via about:config, set browser.urlbar.openintab to true.
3. Visit any web page.
4. Whilst on that page, type "test" in the address bar (or any other search term)
5. Press enter.

=> The search opens in a new tab.

3. Visit about:telemetry
4. On the telemetry page search for browser.search (you may need to reload).

Expected Results

• There should be a browser.search.content.urlbar entry with a record that has a count of one.

Actual Results

• There is a browser.search.content.unknown with a record that has a count of one.

Comment 1

[Mark Banner (:standard8)]

This also applies when using alt-enter for an entry in the address bar.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 1788088 - Correctly record SERP sources when searches are opened in new tabs. r=jteow

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/030feec729dd
Correctly record SERP sources when searches are opened in new tabs. r=jteow

Comment 4

[Iulian Moraru]

Backed out for causing bc failures on browser_new_tab_insert_position.js.

• Push with failures

• Failure log

• Backout link

[task 2025-04-07T14:28:38.662Z] 14:28:38     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js | (aInsertRelatedAfterCurrent=true, aInsertAfterCurrent=false):  http://example.com/#urlbar should be loaded in the current tab. - 
[task 2025-04-07T14:28:38.663Z] 14:28:38     INFO - Buffered messages finished
[task 2025-04-07T14:28:38.666Z] 14:28:38     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js | (aInsertRelatedAfterCurrent=true, aInsertAfterCurrent=false):  Alt+Enter in the URL bar should open page in a new tab at rightmost - Got 3, expected 6
[task 2025-04-07T14:28:38.666Z] 14:28:38     INFO - Stack trace:
[task 2025-04-07T14:28:38.666Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:test_is:1654
[task 2025-04-07T14:28:38.666Z] 14:28:38     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js:doTest:228
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js:test_settings_insertRelatedAfter:332
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js | owner tab is set correctly - 
[task 2025-04-07T14:28:38.667Z] 14:28:38     INFO - Not taking screenshot here: see the one that was previously logged
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - TEST-UNEXPECTED-FAIL | browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js | no opener tab is set - 
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - Stack trace:
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:test_ok:1626
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js:doTest:234
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - chrome://mochitests/content/browser/browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js:test_settings_insertRelatedAfter:332
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:handleTask:1170
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:_runTaskBasedTest:1242
[task 2025-04-07T14:28:38.670Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1383
[task 2025-04-07T14:28:38.671Z] 14:28:38     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:1159
[task 2025-04-07T14:28:38.671Z] 14:28:38     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/<:1058
[task 2025-04-07T14:28:38.671Z] 14:28:38     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js | (aInsertRelatedAfterCurrent=true, aInsertAfterCurrent=false): openerTab should be selected after closing unrelated tab - 
[task 2025-04-07T14:28:38.671Z] 14:28:38     INFO - TEST-PASS | browser/components/tabbrowser/test/browser/tabs/browser_new_tab_insert_position.js | (aInsertRelatedAfterCurrent=true, aInsertAfterCurrent=false): openerTab should be selected after closing related tab - 
[task 2025-04-07T14:28:38.673Z] 14:28:38     INFO - GECKO(1064) | [Child 11795: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f1012172000 == 1 [pid = 11795] [id = 0]

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fd4dea70596b
Correctly record SERP sources when searches are opened in new tabs. r=jteow

Comment 6

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_search_telemetry_sources.js

Backout link: https://hg-edge.mozilla.org/integration/autoland/rev/b3ea294472b49c7b7c835865f682e8682c0d117e

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/search/test/browser/telemetry/browser_search_telemetry_sources.js | Test timed out

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7fcfc3486187
Correctly record SERP sources when searches are opened in new tabs. r=jteow

Comment 8

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/7fcfc3486187

Comment 10

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is reproducible on a 2025-04-20 Firefox Nightly build on Windows 10, using the STR from Comment 0.
Verified as fixed on Firefox Nightly 140.0a1 and Firefox 139.0b3 on Windows 10, Ubuntu 22, macOS 14.