1788595 - Remove legacy translation files notification.dtd and translation.dtd

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, task)

Description

[Eemeli Aro [:eemeli]]

Once bug 1785216 and bug 1734220 are fixed, the following files will have no users in mozilla-central:

• browser/locales/en-US/chrome/browser/translation.dtd
• toolkit/locales/en-US/chrome/global/notification.dtd

However, these files are also used by the Firefox Translations extension, which will need to be correspondingly updated: mozilla/firefox-translations#496

Once that's done, the files should be removed from m-c.

Comment 1

[Francesco Lodolo [:flod]]

@Christoph
This bug is going to remove the last 2 DTDs left in mozilla-central, which means there's nothing left to run the test for bug 467035
https://searchfox.org/mozilla-central/rev/b8493b02562426c78f8213284ea5ce9713ed96a4/dom/tests/mochitest/bugs/test_bug467035.html

Is it OK to remove that test? Or should it be removed from mochitest.ini

I'm not sure there is any other option, since the test seems to rely on a DTD loaded via chrome://

P.S. feel free to redirect if you're not the right person to answer this.

Comment 2

[Christoph Kerschbaumer [:ckerschb]]

(In reply to Francesco Lodolo [:flod] from comment #1)

P.S. feel free to redirect if you're not the right person to answer this.

Gijs is probably the better person to ask. Gijs, can you take a look please?

Comment 3

[:Gijs (he/him)]

The test verifies that we don't expose locale info to the web via DTD files. If there are no DTD files that can't happen, so I think it's fine to remove. I can't imagine anyone adding DTD files back in at this point, so I don't think we really need test coverage for that. However, as a belt+suspenders approach it might be neat to ensure that we actually remove support for DTD files being loaded over chrome/resource protocols. (I'm assuming we can't remove support for DTD in general because XHTML/XML on the web may depend on them, though :peterv might know more about whether that's true if you don't know yourself...)

IOW I think we can remove the test but I think it would be good practice to make Really Sure we've shut the door on DTDs-for-l10n for good.

Comment 4

[Francesco Lodolo [:flod]]

(In reply to :Gijs (he/him) from comment #3)

IOW I think we can remove the test but I think it would be good practice to make Really Sure we've shut the door on DTDs-for-l10n for good.

Thanks. I'll chat with eemeli about it when he's back.

On our side, we're clearly monitoring (and blocking) any attempt to use DTD files in patches. I'm not sure we can remove DTD support completely (even for localization), if nothing else because Thunderbird still relies on it.

Comment 5

[:Gijs (he/him)]

(In reply to Francesco Lodolo [:flod] from comment #4)

(In reply to :Gijs (he/him) from comment #3)

IOW I think we can remove the test but I think it would be good practice to make Really Sure we've shut the door on DTDs-for-l10n for good.

Thanks. I'll chat with eemeli about it when he's back.

On our side, we're clearly monitoring (and blocking) any attempt to use DTD files in patches. I'm not sure we can remove DTD support completely (even for localization), if nothing else because Thunderbird still relies on it.

Makes sense, but even an opt-in build flag or something would be good if we could make it work.

Comment 6

[Francesco Lodolo [:flod]]

Attachment: Bug 1788595 - Remove remaining DTD files from mozilla-central, r=eemeli!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/451d60a492e5
Remove remaining DTD files from mozilla-central, r=eemeli

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/451d60a492e5