1788605 - Align scriptlevel's syntax on MathML Core

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

mathml/relations/css-styling/attribute-mapping-002.html still has failing tests for invalid values of scriptlevel after bug 1667090.

There are several reasons:

• These tests added in https://chromium-review.googlesource.com/c/chromium/src/+/2474780 are a bit incorrect.
• We are trimming whitespace ; it's not clear what to do for now, see https://github.com/w3c/mathml-core/issues/165
• Our parsing is not really strict.

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Bug 1788605: Align scriptlevel's syntax on MathML Core. r=emilio

The ToInteger function is not very strict, so scriptlevel parsing
currently accepts invalid values like "+-1", "--1", "+z1", "+ 1",
"2.0", "-3"" or "200px". To fix that, we perform an extra check
during parsing to ensure that the part after the optional leading
sign is really an <unsigned> number (string of digits).

This patch also fixes some issues in attribute-mapping-002.html
(previously attached attribute not removed, not handling
none/mprescripts specially, gather checks in one loop) and add
more test cases such as the ones mentioned above. The situation of
leading/trailing whitespace is unclear, so testing for things like
" +1" and "+1 " is ignored for now.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cee98ae67ea4
Align scriptlevel's syntax on MathML Core. r=emilio

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35907 for changes under testing/web-platform/tests

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out alongside Bug 1667090, for causing Xpcshell failures on test_css-properties-db.js. CLOSED TREE
Backout link
Push with failures
Link to failure log
Failure line :
TEST-UNEXPECTED-FAIL | devtools/shared/tests/xpcshell/test_css-properties-db.js | xpcshell return code: 0
TEST-UNEXPECTED-FAIL | devtools/shared/tests/xpcshell/test_css-properties-db.js | run_test - [run_test : 73] The static database and platform do not match for

Please also check this new Reftest failure
Failure line : REFTEST TEST-UNEXPECTED-FAIL | layout/reftests/mathml/scriptlevel-1.html == layout/reftests/mathml/scriptlevel-1-ref.html | image comparison, max difference: 255, number of differing pixels: 6594

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b0f86186fb9a
Align scriptlevel's syntax on MathML Core. r=emilio

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 8

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b0f86186fb9a

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/41220 for changes under testing/web-platform/tests

Comment 10

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot