1788621 - Add more rules to determine whether a form with only a cc-number field is a valid cc section

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, task, P1)

Description

[Dimi Lee [:dimi]]

There are cases where sites use a separate form/iframe for a cc-number field (either cc-number in one form, other cc-* in another form, OR each cc-* is in its own form). For thoses, we don't have cc-name or cc-exp to help us determine whether this is a cc form. To support those use cases, we can add two extra rules to identify a valid credit card section:

1. Use a higher confidence threshold.
2. Check whether the <input> is the only non-hidden input field of its form

For rule1, it is implemented in Bug 1783129 , this bug will focus on rule2

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1788621 - Add an extra rule to determine whether a form with only a cc-number field is a valid cc form r=sgalich

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f3e5a79c5252
Add an extra rule to determine whether a form with only a cc-number field is a valid cc form r=sgalich

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset f3e5a79c5252 (Bug 1788621) for causing failures in browser_creditCard_heuristics.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=f3e5a79c52523f073a745c78b3ebe0e5b2b65258&searchStr=os%2Cx%2C11%2Cwebrender%2Cshippable%2Copt%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Ctest-macosx1100-64-shippable-qr%2Fopt-mochitest-browser-chrome-spi-nw%2Cbc7

Log: https://treeherder.mozilla.org/logviewer?job_id=389246341&repo=autoland&lineNumber=6157

Backout: https://hg.mozilla.org/integration/autoland/rev/b018bd7eea017aa7aa5d7fa16a6dafc288a4fbf8

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0553d6f2c2f2
Add an extra rule to determine whether a form with only a cc-number field is a valid cc form r=sgalich

Comment 5

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0553d6f2c2f2