1775233 - Treat form contains only a credit card number field a valid credit card form

Status: RESOLVED FIXED

(Toolkit :: Form Autofill, enhancement, P2)

Description

[Dimi Lee [:dimi]]

With the work in Bug 1681985, we are more confident in how we detect credit card number field. The next step is to relax the restriction regarding a valid credit card section must contain a credit card number field AND (a credit name field or a expiry date field)[1]
We can start with as long as a credit card field is detected in a form, we treat the form as a valid cc section. This will address cases where sites use a separate form/iframe for credit card number field, which is actually not a rare scenario.

[1] https://searchfox.org/mozilla-central/rev/b1a5802e0f73bfd6d2096e5fefc2b47831a50b2d/toolkit/components/formautofill/FormAutofillHandler.jsm#1045-1048

Comment 1

[Dimi Lee [:dimi]]

Attachment: Bug 1775233 - P1. Consider credit card sections that contain only a credit card number field to be valid cc sections r=sgalich

Comment 2

[Dimi Lee [:dimi]]

Attachment: Bug 1775233 - P2. Update testcases to accept credit card forms with only one credit card number field (without autocomplete=cc-number) r=sgalich

Depends on D151806

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a26caa81182
P1. Consider credit card sections that contain only a credit card number field to be valid cc sections r=sgalich
https://hg.mozilla.org/integration/autoland/rev/9917592bf5d8
P2. Update testcases to accept credit card forms with only one credit card number field (without autocomplete=cc-number) r=sgalich

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/4a26caa81182
https://hg.mozilla.org/mozilla-central/rev/9917592bf5d8