1789081 - fontstyle/fontweight attributes should not cancel automatic mathvariant transform on single-char mi

Status: RESOLVED FIXED

(Core :: MathML, defect)

Description

[Frédéric Wang (:fredw)]

Attachment: mi-fontweight-fontstyle.html

This is another cleanup similar to bug 1788645.

This hack was introduced in bug 1027354 to make the MathML1 fontweight/fontstyle attributes work even when we have automatic mathvariant.

We can now remove that now that fontweight/fontstyle are completely removed.

Attached is a testcase that works in Chrome (exp web platform features enabled) but not in Firefox.

Comment 1

[Frédéric Wang (:fredw)]

Sorry the desc is incorrect, actually reading the code it's attributes fontstyle="normal" and fontweight="bold" which incorrectly cancel automatic mathvariant italic.

The testcase was probably failing because we need https://phabricator.services.mozilla.com/D156174

Comment 2

[Frédéric Wang (:fredw)]

Attachment: Bug 1789081: fontstyle/fontweight attributes should not cancel automatic mathvariant transform on single-char mi. r=emilio

Some code was introduced in [1] to fix a regression with deprecated
fontstyle/fontweight attributes. However, this is no longer needed since
implementation for these attributes have been completely removed [2] and
may prevent automatic mathvariant italicization on single-char <mi>.
Also add a WPT test to check for this.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1027354
[2] https://bugzilla.mozilla.org/show_bug.cgi?id=1783841

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93f99157f81e
fontstyle/fontweight attributes should not cancel automatic mathvariant transform on single-char mi. r=emilio

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/35776 for changes under testing/web-platform/tests

Comment 5

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/93f99157f81e

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by jgraham