1789245 - When "openDevTools" is not passed: installTemporaryAddon: Error: undefined passed where a value is required

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Rob Wu [:robwu]]

Originally reported at https://github.com/mozilla/web-ext/issues/2499

STR:

1. Create a directory containing an extension (e.g. by taking an existing extension/xpi file and unzipping it)
2. Install web-ext if needed.
3. Run web-ext run -f nightly

Expected:

• Nightly launches with the extension installed.

Actual:

• Nightly cannot launch. The following message is displayed by web-ext:

WebExtError: installTemporaryAddon: Error: Error: undefined passed where a value is required

I believe that this is due to a change in https://searchfox.org/mozilla-central/rev/918fd22032de3a0025d6e9f4fcc8b7f625315068/devtools/shared/specs/addon/addons.js#13

If I look at other protocol definitions, then I suppose that prepending nullable: to the boolean would fix this issue.

Comment 1

[Rob Wu [:robwu]]

I'll attach a patch to get this rolling.

Comment 2

[Rob Wu [:robwu]]

Attachment: Bug 1789245 - [devtools] Mark openDevTools as nullable for installTemporaryAddon

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/863b5207dfe1
[devtools] Mark openDevTools as nullable for installTemporaryAddon r=devtools-backward-compat-reviewers,ochameau

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/863b5207dfe1