1789298 - Pressing Del key while filling the login credentials deletes it from the password manager instantly without a prompt

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P1)

Description

[Hanabishi]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0

Steps to reproduce:

1. Open any website you have the login credentials stored.
2. Open the autofill menu for a login form.
3. Press "Del" key.

Actual results:

It deletes the selected credentials from the password manager instantly without a prompt, and also instantly removes it from the cloud if you have the sync on.
So 1 accidental key press completely purges your credentials from your account and all devices.

Expected results:

At least have a prompt, like when deleting the credentials from the password manager.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Password Manager' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Ryan Safaeian [:rsafaeian]]

Attachment: Bug 1789298 - Make removeValueAt and isRemovableAt return false for LoginAutoCompleteResult and remove associated tests. r=#credential-management-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cbd197f5790c
Make removeValueAt and isRemovableAt return false for LoginAutoCompleteResult and remove associated tests. r=issammani

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/cbd197f5790c

Comment 6

[Ina Popescu, Desktop QA]

I've replicated this issue using Nightly 98.0a1 (2022-01-15) on Windows 10 x64 following the STR from Comment 0.
Verified as fixed in the latest Firefox 128.0b9 version on Windows 10 x64, macOS 13, and Ubuntu 22.04, as the issue no longer occurs.