1789358 - Blocked popup preference menu has white text on light grey background in Private window

Status: RESOLVED FIXED

(Firefox :: Menus, defect, P3)

Description

[Nicolas Chevobbe [:nchevobbe]]

Attachment: CleanShot 2022-09-06 at 09.02.37.png

See screenshot

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Menus' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Mike Conley (:mconley) (:⚙️)]

This appears to be a regression introduced by bug 1751481. Any idea what's going on here, pbz?

Comment 3

[Paul Zühlcke [:pbz]]

Thanks!
I can reproduce. This affects private the dark-themed browsing windows where normal windows are light themed (following system theme).
Taking a look.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1751481

Comment 5

[Paul Zühlcke [:pbz]]

Doesn't seem to affect Windows (11). Might be a macOS-only issue. I ran into similar problems in Bug 1749377 where the font color would not update correctly on macOS. This was fixed by https://phabricator.services.mozilla.com/D136933

Comment 6

[Paul Zühlcke [:pbz]]

Attachment: Bug 1789358 - Recompute widget color scheme before showing. r=emilio!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afd5d96808f2
Recompute widget color scheme before showing. r=emilio

Comment 8

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/afd5d96808f2

Comment 9

[Monica Chiorean]

Attachment: Screenshot.png

I tried to reproduce the issue on Mac 10.13, using build 106.0a1(2022-09-06) and Beta 106.0b5 and same menu is displayed on Private Browsing as on screenshot. Is this expected? Thank you.

Comment 10

[Nicolas Chevobbe [:nchevobbe]]

I won't be able to check my OSX machine for a while, but it didn't look like that, the private window was some shade of purple