1789802 - CI crash reports sometimes use generic crash signature "application crashed [@ MOZ_Crash(char const*, int, char const*)]" but shouldn't

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Since bug 1779631 landed, many (~500 crash reports from CI in the last 16h) use the generic crash signature application crashed [@ MOZ_Crash(char const*, int, char const*)].

Example log: https://treeherder.mozilla.org/logviewer?job_id=389815378&repo=autoland&lineNumber=1317

[task 2022-09-08T03:35:51.436Z] 03:35:51     INFO -  Thread 0 MainThread (crashed)
[task 2022-09-08T03:35:51.436Z] 03:35:51     INFO -   0  XUL!MOZ_Crash(char const*, int, char const*) [Assertions.h:2df511a16e4194617632cce3f261312c8e068620 : 261]
[task 2022-09-08T03:35:51.436Z] 03:35:51     INFO -      Found by: inlining
[task 2022-09-08T03:35:51.437Z] 03:35:51     INFO -   1  XUL!mozilla::net::CheckForBrokenChromeURL(nsILoadInfo*, nsIURI*) [nsNetUtil.cpp:2df511a16e4194617632cce3f261312c8e068620 : 3898 + 0xa]
[task 2022-09-08T03:35:51.437Z] 03:35:51     INFO -       rax = 0x00000001093da560    rdx = 0xfffffffffffffff4
[task 2022-09-08T03:35:51.437Z] 03:35:51     INFO -       rcx = 0x00000001093d8588    rbx = 0x00007ffee68bfdb8
[task 2022-09-08T03:35:51.437Z] 03:35:51     INFO -       rsi = 0x000000011b46f2a8    rdi = 0x00007ffee68bf820
[task 2022-09-08T03:35:51.438Z] 03:35:51     INFO -       rbp = 0x00007ffee68bff00    rsp = 0x00007ffee68bfda0
[task 2022-09-08T03:35:51.438Z] 03:35:51     INFO -        r8 = 0x0000000000000000     r9 = 0x0000000000000001
[task 2022-09-08T03:35:51.438Z] 03:35:51     INFO -       r10 = 0x0000000000000000    r11 = 0xffffffffedf6b2f9
[task 2022-09-08T03:35:51.438Z] 03:35:51     INFO -       r12 = 0x0003001100000000    r13 = 0x0002002100000017
[task 2022-09-08T03:35:51.439Z] 03:35:51     INFO -       r14 = 0x000000010968a860    r15 = 0x0000000128f885e0
[task 2022-09-08T03:35:51.439Z] 03:35:51     INFO -       rip = 0x000000010bd1b187
[task 2022-09-08T03:35:51.439Z] 03:35:51     INFO -      Found by: given as instruction pointer in context

Code sheriffs would like to keep the old behavior in having a more unique crash signature used.

Comment 1

[Gabriele Svelto [:gsvelto]]

Looking into this

Comment 2

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1789802 - Ignore MOZ_Crash() functions when generating a singature for an automation crash r=KrisWright

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/864dbac96c87
Ignore MOZ_Crash() functions when generating a singature for an automation crash r=mstange

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/864dbac96c87

Comment 5

[Intermittent Failures Robot]

3 failures in 3616 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 3

Platform and build breakdown:

• macosx1015-64-shippable-qr: 3
  • opt: 3

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1789802&startday=2022-09-05&endday=2022-09-11&tree=all