Closed Bug 1789906 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 35837 - blink: Retain flex layout behaviour for SVG children.

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
107 Branch
Tracking Flags:
Tracking Status
firefox107 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 35837 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/35837
Details from upstream follow.

Khushal Sagar <khushalsagar@chromium.org> wrote:

blink: Retain flex layout behaviour for SVG children.

SVG children resolve min-width/min-height: auto to 0 by default due to
overflow:hidden in UA stylesheet. This changed with
CSSOverflowForReplacedElements which added overflow:clip to these
elements and as a result used the minimum size based on SVG's intrinsic
size.

Fix the above by retaining the old behaviour and treating overflow:clip
same as overflow:hidden for these elements. The discussion for the final
solution continues at: https://github.com/w3c/csswg-drafts/issues/7714.

R=ikilpatrick@chromium.org

Bug:1358820
Change-Id: I79fb2e334ca72807ca6e3b12d85c1f8a33a9f086
Reviewed-on: https://chromium-review.googlesource.com/3884796
WPT-Export-Revision: 48866990aa26cce0b199f6b33301f21fa061fdbf

Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests

Status Summary

Firefox

PASS: 3

Chrome

PASS: 1
FAIL: 2

Safari

PASS: 1
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/054553a40bf3 [wpt PR 35837] - blink: Remove 'overflow:clip' UA CSS for root svg elements., a=testonly https://hg.mozilla.org/integration/autoland/rev/a3d240cae4f0 [wpt PR 35837] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/054553a40bf3
https://hg.mozilla.org/mozilla-central/rev/a3d240cae4f0

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox107: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 107 Branch
You need to log in before you can comment on or make changes to this bug.