1790127 - [foxfooding] The welcome screen of the onboarding wizard has a "Skip this step" button

Status: VERIFIED FIXED

(Firefox :: Messaging System, enhancement, P3)

Description

[Peter deHaan [:pdehaan]]

Attachment: issue39.png

Firefox Version: Mozilla/5.0 (X11; Linux x86_64; rv:104.0) Gecko/20100101 Firefox/104.0
Window Size (inner width and height): 1438x1367
GitHub Username: @Vinnl

Steps to Reproduce

1. Have Nightly as your default browser
2. Open about:welcome

Expected Behavior

There's a "Set up in seconds" button.

Actual Behavior

There's also a "Skip this step" button, but it appears to do exactly the same as "Set up in seconds".

Attachment

Link to the original attachment

Comment 1

[Ania]

Almost no users will encounter this situation, but I tend to agree there's a UX inconsistency in this case.
We should probably consider removing "Skip this step button" for both new and existing users who see "Set up in seconds" Intro screen.

Comment 2

[Shane Hughes [:aminomancer]]

Attachment: Bug 1790127 - Hide the secondary CTA on welcome screen if the primary action will have no effect. r=Mardak

If Firefox is the default app and pinned to the dock/taskbar, the
primary CTA on the welcome screen will have the same effect as the
secondary CTA. So we can hide one of them. The non-MR page already has
this feature and elects to hide the secondary CTA, so do the same here.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42915f752ad4
Hide the secondary CTA on welcome screen if the primary action will have no effect. r=Mardak

Comment 4

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/42915f752ad4

Comment 5

[Marius Coman [:mcoman], Ecosystem QA - PTO until 8th of November, for any requests ping :cmuresan]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (106.0a1 Build ID - 20220914213649) installed on Windows 10 x64, macOS 11.6.7, and Linux Mint 20.2 x64. Now, I can confirm "Skip this step" button is no longer displayed on the "Set up in seconds" Onboarding screen and modal.