1790372 - Implement "network.responseCompleted" event

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Comment 1

[Julian Descottes [:jdescottes]]

Valentin, another question (sorry :) )
We have a PR on the fetch spec to add a trigger for BiDi's "response completed" event: https://whatpr.org/fetch/1540.html#fetch-finale step 3.3.8

If response is a network error, run the WebDriver BiDi fetch error steps with request. Otherwise run the WebDriver BiDi response completed steps with request and response.

Do you what would be a good match to observe this from chrome privileged JS?

At the moment we started our implementation by reusing the DevTools NetworkObserver logic, but to detect the end of a response we wait for the request input stream to be closed (usually seems to trigger from https://searchfox.org/mozilla-central/rev/d62c4c4d5547064487006a1506287da394b64724/devtools/shared/network-observer/NetworkResponseListener.sys.mjs#593)

But for redirects, the redirected request and response are already partly processed when we detect that the original stream closes. So I imagine we should observe something else here. Any idea?

Comment 2

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790372 - [bidi] Add basic support for network.responseCompleted event

NetworkObserver addResponseContent is the last observable callback for a given request, so let's start by using this as the trigger for
responseCompleted. However, as noted on the bug and on Bug 1809210, this does not meet the expectations from the spec completely so we might have to
change to another observable later.

Comment 3

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790372 - [wdspec] Add wdspec tests for network.responseCompleted

Depends on D166373

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1790372 - [bidi] Do not include the charset in the mimeType

Depends on D166373

Comment 5

[Phabricator Automation]

Comment on attachment 9311845 [details]
Bug 1790372 - [bidi] Do not include the charset in the mimeType

Revision D166599 was moved to bug 1809854. Setting attachment 9311845 [details] to obsolete.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6956ef91ed6f
[bidi] Add basic support for network.responseCompleted event r=webdriver-reviewers,whimboo
https://hg.mozilla.org/integration/autoland/rev/89a09894a67b
[wdspec] Add wdspec tests for network.responseCompleted r=webdriver-reviewers,whimboo

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37899 for changes under testing/web-platform/tests

Comment 8

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/6956ef91ed6f
https://hg.mozilla.org/mozilla-central/rev/89a09894a67b

Comment 9

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot