1809290 - Add wdspec tests for BiDi network events subscribed for a single context

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P1)

Description

[Julian Descottes [:jdescottes] (PTO -> Jan 5th)]

With the initial implementation of the 3 first network events (network.beforeRequestSent, network.responseStarted, network.responseCompleted), all wdspec tests are only checking subscriptions to all contexts.

Since this event is handled from the parent process it's important to check that when monitoring events for a given browsing context, you don't receive events from other contexts.

Comment 1

[Julian Descottes [:jdescottes] (PTO -> Jan 5th)]

Attachment: Bug 1809290 - [wdspec] Add BiDi network event tests subscribing to a single context

Depends on D166374

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

(In reply to Julian Descottes [:jdescottes] from comment #0)

Since this event is handled from the parent process it's important to check that when monitoring events for a given browsing context, you don't receive events from other contexts.

Given that in our implementation we got it implemented in the parent process we cannot assume the same for Chrome or other browsers. At the same time other browsers also could have eg. navigation events implemented via the parent process. As such we might have to add such a test for all the events that we currently support. Happy to file a new bug and to discuss in next week's triage meeting if we agree.

Comment 3

[Julian Descottes [:jdescottes] (PTO -> Jan 5th)]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+1] from comment #2)

(In reply to Julian Descottes [:jdescottes] from comment #0)

Since this event is handled from the parent process it's important to check that when monitoring events for a given browsing context, you don't receive events from other contexts.

Given that in our implementation we got it implemented in the parent process we cannot assume the same for Chrome or other browsers. At the same time other browsers also could have eg. navigation events implemented via the parent process. As such we might have to add such a test for all the events that we currently support. Happy to file a new bug and to discuss in next week's triage meeting if we agree.

Right I just remembered Sasha filed a general bug 1802537

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a36380efa4c8
[wdspec] Add BiDi network event tests subscribing to a single context r=webdriver-reviewers,whimboo

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Failed to create upstream wpt PR due to merge conflicts. This requires fixup from a wpt sync admin.

Comment 6

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a36380efa4c8

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/37932 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot