Closed
Bug 1790407
Opened 2 years ago
Closed 2 years ago
Close button is not working for the mobile pick up card
Categories
(Firefox :: Firefox View, defect, P1)
Tracking
()
VERIFIED
FIXED
106 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr91 | --- | unaffected |
| firefox-esr102 | --- | unaffected |
| firefox104 | --- | unaffected |
| firefox105 | --- | unaffected |
| firefox106 | --- | verified |
People
(Reporter: Gabi, Assigned: niklas)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [fidefe-2022-mr1-firefox-view])
Attachments
(1 file)
Found in
- Nightly 106.0a1
Affected versions
- Nightly 106.0a1
Tested platforms
- Affected platforms: Windows 10x64, Ubuntu 18.4 and macOS 10.12.6
Steps to reproduce
- Launch Firefox
- Go to Firefox View tab pick up
- Click Continue button to sign in with FxA account
- Sign In with account
- Return to Firefox View and click Close on the mobile pick up card button
Expected result
- Mobile pick up message card is closed.
Actual result
- Close button is not working for the mobile pick up card
Regression range
- First bad: 106.0a1 (2022-09-09)
- Last good: 106.0a1 (2022-09-08)
- Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b0f7a20d14a3b1c4ea192a85028288c8b3d2df7&tochange=0e3963842e57b86dd0fb9e5f2e8eb8eab02192ed
- Potentially regressed by: Bug 1789226 - Show zap gradient border for tab pickup cards. r=sclements
|
Reporter | |
Updated•2 years ago
|
Has STR: --- → yes
Keywords: regression
|
||
Updated•2 years ago
|
Has STR: yes → ---
Keywords: regression
|
|
||
Comment 1•2 years ago
|
||
Oops. Sorry didn't mean to do that!
|
|
||
Updated•2 years ago
|
Has STR: --- → yes
Keywords: regression
|
||
Comment 2•2 years ago
|
||
We shouldn't ship with non-functioning buttons.
Severity: S3 → S2
Priority: -- → P1
|
|
||
Comment 3•2 years ago
|
||
Agreed. Chatting w/ Sarah about this now.
|
||
Comment 4•2 years ago
|
||
Niklas, would you be able to look at the close button in the mobile promo?
Flags: needinfo?(nbaumgardner)
|
||
Comment 5•2 years ago
|
||
Set release status flags based on info from the regressing bug 1789226
status-firefox104:
--- → unaffected
status-firefox105:
--- → unaffected
status-firefox-esr102:
--- → unaffected
status-firefox-esr91:
--- → unaffected
|
Assignee | |
Comment 7•2 years ago
|
||
|
||
Updated•2 years ago
|
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
|
|
||
Updated•2 years ago
|
Whiteboard: [fidefe-2022-mr1-firefox-view]
|
||
Updated•2 years ago
|
Pushed by gijskruitbosch@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9c9951c88959
Close button for mobile pick up card should be clickable. r=Gijs
|
||
Comment 9•2 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 106 Branch
|
|
Reporter | |
Comment 10•2 years ago
|
||
Verified as fixed in Nightly 106.0a1 with Windows 10x64, Ubuntu 18.4 and macOS 10.12.6.
|
|
Reporter | |
Updated•2 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•