1790428 - ExperimentFakes.enrollWithRollout skips enrollment logic

Status: RESOLVED FIXED

(Firefox :: Nimbus Desktop Client, defect, P3)

Description

[Beth Rennie [:beth] (she/her)]

It directly calls ExperimentStore.addEnrollment, skipping all logic in ExperimentManager.enroll().

Comment 1

[Beth Rennie [:beth] (she/her)]

Attachment: Bug 1790428 - Remove ExperimentFakes.enrollWithRollout r?chumphreys

enrollWithRollout skipped all enrollment logic in ExperimentManager.enroll by
calling ExperimentStore.addEnrollment directly. This prevents prefs being set
by Nimbus correctly when enrolling. enrollWithFeatureConfig already supports
enrolling as a rollout, so all uses of enrollWithRollout have been replaced.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9db188aa6dac
Remove ExperimentFakes.enrollWithRollout r=chumphreys

Comment 3

[Cristian Tuns]

Backed out for causing multiple failures

• Backout link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js | Not called, not enrolling in rollout feature already exists - false == true - {"filename":"chrome://mochitests/content/browser/toolkit/components/nimbus/test/browser/browser_remotesettingsexperimentloader_remote_defaults.js","name":"test_finalizeRemoteConfigs_cleanup","sourceId":685,"lineNumber":394,"columnNumber":10,"source

And: https://treeherder.mozilla.org/logviewer?job_id=458158516&repo=autoland
TEST-UNEXPECTED-FAIL | browser/base/content/test/about/browser_aboutSupport.js | Rendered the expected rollout -

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9a936171ae4
Remove ExperimentFakes.enrollWithRollout r=chumphreys

Comment 5

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/7d84e159579eeeaccc7972169795a7ba02ec8383

Push with failures

Failure log ->

Buffered messages finished
[task 2024-05-15T22:11:37.429Z] 22:11:37     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js | Uncaught exception in test bound test_experiment_messaging_system_impressions - wait and retrieve telemetry event - timed out after 50 tries.
[task 2024-05-15T22:11:37.430Z] 22:11:37     INFO - Leaving test bound test_experiment_messaging_system_impressions
[task 2024-05-15T22:11:37.431Z] 22:11:37     INFO - GECKO(2054) | [Parent 2054, Main Thread] WARNING: Ignoring duplicate observer: browser.shopping.experience2023.autoOpen.userEnabled: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:2905
[task 2024-05-15T22:11:37.432Z] 22:11:37     INFO - GECKO(2054) | [Parent 2054, Main Thread] WARNING: Ignoring duplicate observer: browser.shopping.experience2023.optedIn: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:2905
[task 2024-05-15T22:11:37.434Z] 22:11:37     INFO - GECKO(2054) | [Parent 2054, Main Thread] WARNING: Ignoring duplicate observer: browser.shopping.experience2023.autoOpen.userEnabled: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:2905
[task 2024-05-15T22:11:37.435Z] 22:11:37     INFO - GECKO(2054) | [Parent 2054, Main Thread] WARNING: Ignoring duplicate observer: browser.shopping.experience2023.optedIn: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:2905
[task 2024-05-15T22:11:37.435Z] 22:11:37     INFO - GECKO(2054) | MEMORY STAT | vsize 12044MB | residentFast 520MB | heapAllocated 322MB
[task 2024-05-15T22:11:37.436Z] 22:11:37     INFO - TEST-OK | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js | took 6736ms
[task 2024-05-15T22:11:37.436Z] 22:11:37     INFO - GECKO(2054) | [Child 2219: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 7f23aa783800 == 2 [pid = 2219] [id = 6]
[task 2024-05-15T22:11:37.437Z] 22:11:37     INFO - GECKO(2054) | [Child 2219: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (7f23a9608200) [pid = 2219] [serial = 14] [outer = 0]
[task 2024-05-15T22:11:37.441Z] 22:11:37     INFO - GECKO(2054) | [Child 2219: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 4 (7f23aa783c00) [pid = 2219] [serial = 15] [outer = 7f23a9608200]
[task 2024-05-15T22:11:37.441Z] 22:11:37     INFO - checking window state
[task 2024-05-15T22:11:37.442Z] 22:11:37     INFO - Not taking screenshot here: see the one that was previously logged
[task 2024-05-15T22:11:37.442Z] 22:11:37     INFO - TEST-UNEXPECTED-FAIL | browser/components/privatebrowsing/test/browser/browser_privatebrowsing_about_nimbus_impressions.js | Found an unexpected browser window at the end of test run - 
[task 2024-05-15T22:11:37.443Z] 22:11:37     INFO - GECKO(2054) | must wait for focus
[task 2024-05-15T22:11:37.514Z] 22:11:37     INFO - GECKO(2054) | [Parent 2054, Compositor] WARNING: Possibly dropping task posted to updater thread: file /builds/worker/checkouts/gecko/gfx/layers/apz/src/APZUpdater.cpp:395

Comment 6

[Beth Rennie [:beth] (she/her)]

Third time's the charm.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c89b2129d200
Remove ExperimentFakes.enrollWithRollout r=chumphreys

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/c89b2129d200